You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Martin Vysny (JIRA)" <ji...@apache.org> on 2018/06/07 06:33:00 UTC

[jira] [Created] (KAFKA-7016) Reconsider the "avoid the expensive and useless stack trace for api exceptions" practice

Martin Vysny created KAFKA-7016:
-----------------------------------

             Summary: Reconsider the "avoid the expensive and useless stack trace for api exceptions" practice
                 Key: KAFKA-7016
                 URL: https://issues.apache.org/jira/browse/KAFKA-7016
             Project: Kafka
          Issue Type: Bug
            Reporter: Martin Vysny


I am trying to write a Kafka Consumer; upon running it only prints out:


{{ org.apache.kafka.common.errors.InvalidGroupIdException: The configured groupId is invalid}}

Note that the stack trace is missing, so that I have no information which part of my code is bad and need fixing; I also have no information which Kafka Client method has been called. Upon closer examination I found this in ApiException:

 

{{/* avoid the expensive and useless stack trace for api exceptions */}}
{{@Override}}
{{public Throwable fillInStackTrace() {}}
{{ return this;}}
{{}}}

 

I think it is a bad practice to hide all useful debugging info and trade it for dubious performance gains. Exceptions are for exceptional code flow which are allowed to be slow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)