You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "mck (JIRA)" <ji...@apache.org> on 2016/08/12 00:06:22 UTC
[jira] [Comment Edited] (CASSANDRA-11706) Tracing payload not
passed through newSession(..)
[ https://issues.apache.org/jira/browse/CASSANDRA-11706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405210#comment-15405210 ]
mck edited comment on CASSANDRA-11706 at 8/12/16 12:05 AM:
-----------------------------------------------------------
^ oh no, someone took my alias! I'm working on this today.
The latest patch also includes a unit test, and is ready for review.
was (Author: michaelsembwever):
^ oh no, someone took my alias! I working on this today.
> Tracing payload not passed through newSession(..)
> -------------------------------------------------
>
> Key: CASSANDRA-11706
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11706
> Project: Cassandra
> Issue Type: Bug
> Reporter: mck
> Assignee: mck
> Priority: Minor
> Labels: tracing
> Fix For: 3.x
>
> Attachments: trunk-11706.txt
>
>
> Caused by CASSANDRA-10392
> There's a small bug in https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tracing/Tracing.java#L153
> {noformat}
> public UUID newSession(UUID sessionId, Map<String,ByteBuffer> customPayload)
> {
> return newSession(sessionId, TraceType.QUERY, Collections.EMPTY_MAP);
> }{noformat}
> in that it passes on an {{EMPTY_MAP}} instead of the {{customPayload}}.
> I've marked this as "minor" as custom tracing plugins can easily enough workaround it by also overriding the {{newSession(UUID sessionId, Map<String,ByteBuffer> customPayload)}} method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)