You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2026/06/11 12:27:48 UTC
[PR] feat(queue): add message + batch unit catalogs to batch-write metrics and FODC observability improvements [skywalking-banyandb]
hanahmily opened a new pull request, #1171:
URL: https://github.com/apache/skywalking-banyandb/pull/1171
## Summary
- **Batch-write metric catalogs**: Add `totalBatchStarted`/`totalBatchFinished` and `totalMessageStarted`/`totalMessageFinished` counters + latency histogram to the queue sub path; fix started/finished symmetry so `started` ticks only immediately before `Rev()` (pre-Rev early returns produce no metric change).
- **Group label population**: Wire `metadata.GetGroup()` into `bus.NewBatchMessageWithNodeAndGroup` in all four liaison/grpc handlers (measure, stream, trace, topn) so all queue pub/sub metrics carry a non-empty `group` label.
- **collectDisk fix**: Change `return` → `continue` in the first `collectDisk` loop so a single failing disk path does not abort gauge updates for all healthy paths.
- **FODC dashboard improvements**: Add topology panels (pod-to-pod flows table) that were accidentally dropped; add batch-write panels to the workload dashboard; add `grafana-fodc-nodes.json` and `grafana-fodc-workload.json` docs.
- **E2E verification**: Add a kind-based e2e test (`test-fodc-dashboard-e2e.yml`) that verifies all FODC Grafana dashboard metrics are exported, non-empty, carry required label dimensions, and canonical OAP groups (`sw_metadata`, `sw_records`, `sw_metricsMinute`) have positive write traffic; add a dashboard-sync CI check.
## Test plan
- [ ] `make lint` — passes clean (0 issues)
- [ ] `go test ./banyand/queue/pub/... ./banyand/queue/sub/... ./banyand/observability/services/... ./banyand/liaison/grpc/... -count=1` — all pass
- [ ] FODC e2e kind test (`test-fodc-dashboard-e2e.yml`) — passes after regression verification in GKE cluster
- [ ] Dashboard sync check (`check-dashboard-sync.sh`) — all dashboard metrics covered by the three test lists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(queue): add message + batch unit catalogs to batch-write metrics and FODC observability improvements [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #1171:
URL: https://github.com/apache/skywalking-banyandb/pull/1171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(queue): add message + batch unit catalogs to batch-write metrics and FODC observability improvements [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1171:
URL: https://github.com/apache/skywalking-banyandb/pull/1171#issuecomment-4680808521
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1171?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 41.15%. Comparing base ([`3530dd9`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/3530dd9b5cefaa4fef60eec91ecbfbdfcaf243c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7b09fb8`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/7b09fb8400e73f5f454ad89899be6e4714287ff5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 291 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
- Coverage 45.97% 41.15% -4.83%
==========================================
Files 328 196 -132
Lines 55505 20390 -35115
==========================================
- Hits 25520 8391 -17129
+ Misses 27909 11149 -16760
+ Partials 2076 850 -1226
```
| [Flag](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1171/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1171/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.15% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1171?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org