You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by si...@apache.org on 2007/02/02 17:44:47 UTC

svn commit: r502651 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml

Author: sichen
Date: Fri Feb  2 08:44:46 2007
New Revision: 502651

URL: http://svn.apache.org/viewvc?view=rev&rev=502651
Log:
commented out code which auto-filled in PaymentApplication.billingAccountId from Invoice.billingAccountId, which will cause problems when there are multiple payment methods

Modified:
    ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml

Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml?view=diff&rev=502651&r1=502650&r2=502651
==============================================================================
--- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml (original)
+++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml Fri Feb  2 08:44:46 2007
@@ -134,6 +134,10 @@
                 <log level="warning" message="Create Payment Application: Amount to apply [${paymentAppl.amountApplied}] is greater than the outstanding amount [${notApplied}] of the invoice [${invoice.invoiceId}]. Creating Payment Application for outstanding amount [${notApplied}] instead."/>
                 <set field="paymentAppl.amountApplied" from-field="notApplied"/>
             </if-compare-field>
+            
+            <!-- this is intentionally commented out because auto-filling billingAccountId from invoice to payment application will cause double-counting of
+            amount charged to billing accounts if there are multiple payment methods (ie, billing account + credit card)
+            see https://issues.apache.org/jira/browse/OFBIZ-682 -->
             <if-not-empty field-name="invoice.billingAccountId">
                 <set field="paymentAppl.billingAccountId" from-field="invoice.billingAccountId"/>
             </if-not-empty>