You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by Nuwan Jayawardene <ns...@gmail.com> on 2021/08/10 17:49:29 UTC
JDK version mismatch in Synapse
Hi all,
while working recently on a local build of Synapse I ran across a build
failure.
Upon further inspection of the pom I found that Synapse is being built on
Java 1.6.
[image: image.png]
My local jdk installation was 1.8 so with a simple pom update it got built
successfully.
However, then I found out that the CI/CD pipeline has been configured to
build on 1.7.
[image: image.png]
This is in contrast to other forks of synapse, notably WSO2-synapse
<https://github.com/wso2/wso2-synapse> which has both 1.8 in the pom,
[image: image.png]
and 1.8 in the CD pipeline definition.
[image: image.png]
I'm raising this since I ran into a build failure while trying to merge a
PR in my personal fork and the checks failed. The culprit turned out to be
the deprecated java version.
[image: image.png]
Would appreciate some thoughts on this. I'm more than happy to create a PR
and bump the JDK versions since it's a simple fix.
Kind regards
--
*Nuwan Jayawardene*
Assistant Lecturer, Informatics Institute of Technology (IIT).
Research Assistant, University of Moratuwa
Tel - +94 71 181 3299
https://www.linkedin.com/m/in/nuwanjaya
Re: JDK version mismatch in Synapse
Posted by Nuwan Jayawardene <ns...@gmail.com>.
Hi all,
I sent a PR to the Synapse master, linked here:
https://github.com/apache/synapse/pull/53
I had some prior commits when I was testing out Synapse, all of which I
reverted before sending the PR.
So apologies in advance for having a bit of a polluted PR.
Kind regards
[image: image.gif]
On Thu, Aug 12, 2021 at 9:46 AM Isuru Udana <is...@gmail.com> wrote:
> Hi Nuwan,
>
> We haven't stopped supporting JDK 1.7. We need to take it into a
> separate discussion on whether we are ok to stick to JDK 1.8.
> Can you please send a PR by updating JDK version to 1.7 in the pom?
>
> Thanks.
>
> On Wed, Aug 11, 2021 at 12:24 AM Senaka Fernando <se...@apache.org>
> wrote:
>
>> Would be worth you creating a PR.
>>
>> On Tue, Aug 10, 2021 at 6:50 PM Nuwan Jayawardene <ns...@gmail.com>
>> wrote:
>>
>>> Hi all,
>>> while working recently on a local build of Synapse I ran across a build
>>> failure.
>>> Upon further inspection of the pom I found that Synapse is being built
>>> on Java 1.6.
>>> [image: image.png]
>>> My local jdk installation was 1.8 so with a simple pom update it got
>>> built successfully.
>>> However, then I found out that the CI/CD pipeline has been configured to
>>> build on 1.7.
>>> [image: image.png]
>>>
>>> This is in contrast to other forks of synapse, notably WSO2-synapse
>>> <https://github.com/wso2/wso2-synapse> which has both 1.8 in the pom,
>>> [image: image.png]
>>> and 1.8 in the CD pipeline definition.
>>> [image: image.png]
>>>
>>> I'm raising this since I ran into a build failure while trying to merge
>>> a PR in my personal fork and the checks failed. The culprit turned out to
>>> be the deprecated java version.
>>> [image: image.png]
>>>
>>> Would appreciate some thoughts on this. I'm more than happy to create a
>>> PR and bump the JDK versions since it's a simple fix.
>>>
>>> Kind regards
>>> --
>>> *Nuwan Jayawardene*
>>> Assistant Lecturer, Informatics Institute of Technology (IIT).
>>> Research Assistant, University of Moratuwa
>>> Tel - +94 71 181 3299
>>> https://www.linkedin.com/m/in/nuwanjaya
>>>
>>>
>>>
>
> --
> *Isuru Udana*
> Associate Director/Architect
>
>
>
> *; WSO2 Inc.; http://wso2.com <http://wso2.com>email: isudana@gmail.com
> <is...@gmail.com> *
>
>
>
--
*Nuwan Jayawardene*
Assistant Lecturer, Informatics Institute of Technology (IIT).
Research Assistant, University of Moratuwa
Tel - +94 71 181 3299
https://www.linkedin.com/m/in/nuwanjaya
Re: JDK version mismatch in Synapse
Posted by Isuru Udana <is...@gmail.com>.
Hi Nuwan,
We haven't stopped supporting JDK 1.7. We need to take it into a
separate discussion on whether we are ok to stick to JDK 1.8.
Can you please send a PR by updating JDK version to 1.7 in the pom?
Thanks.
On Wed, Aug 11, 2021 at 12:24 AM Senaka Fernando <se...@apache.org> wrote:
> Would be worth you creating a PR.
>
> On Tue, Aug 10, 2021 at 6:50 PM Nuwan Jayawardene <ns...@gmail.com>
> wrote:
>
>> Hi all,
>> while working recently on a local build of Synapse I ran across a build
>> failure.
>> Upon further inspection of the pom I found that Synapse is being built on
>> Java 1.6.
>> [image: image.png]
>> My local jdk installation was 1.8 so with a simple pom update it got
>> built successfully.
>> However, then I found out that the CI/CD pipeline has been configured to
>> build on 1.7.
>> [image: image.png]
>>
>> This is in contrast to other forks of synapse, notably WSO2-synapse
>> <https://github.com/wso2/wso2-synapse> which has both 1.8 in the pom,
>> [image: image.png]
>> and 1.8 in the CD pipeline definition.
>> [image: image.png]
>>
>> I'm raising this since I ran into a build failure while trying to merge a
>> PR in my personal fork and the checks failed. The culprit turned out to be
>> the deprecated java version.
>> [image: image.png]
>>
>> Would appreciate some thoughts on this. I'm more than happy to create a
>> PR and bump the JDK versions since it's a simple fix.
>>
>> Kind regards
>> --
>> *Nuwan Jayawardene*
>> Assistant Lecturer, Informatics Institute of Technology (IIT).
>> Research Assistant, University of Moratuwa
>> Tel - +94 71 181 3299
>> https://www.linkedin.com/m/in/nuwanjaya
>>
>>
>>
--
*Isuru Udana*
Associate Director/Architect
*; WSO2 Inc.; http://wso2.com <http://wso2.com>email: isudana@gmail.com
<is...@gmail.com> *
Re: JDK version mismatch in Synapse
Posted by Senaka Fernando <se...@apache.org>.
Would be worth you creating a PR.
On Tue, Aug 10, 2021 at 6:50 PM Nuwan Jayawardene <ns...@gmail.com> wrote:
> Hi all,
> while working recently on a local build of Synapse I ran across a build
> failure.
> Upon further inspection of the pom I found that Synapse is being built on
> Java 1.6.
> [image: image.png]
> My local jdk installation was 1.8 so with a simple pom update it got built
> successfully.
> However, then I found out that the CI/CD pipeline has been configured to
> build on 1.7.
> [image: image.png]
>
> This is in contrast to other forks of synapse, notably WSO2-synapse
> <https://github.com/wso2/wso2-synapse> which has both 1.8 in the pom,
> [image: image.png]
> and 1.8 in the CD pipeline definition.
> [image: image.png]
>
> I'm raising this since I ran into a build failure while trying to merge a
> PR in my personal fork and the checks failed. The culprit turned out to be
> the deprecated java version.
> [image: image.png]
>
> Would appreciate some thoughts on this. I'm more than happy to create a PR
> and bump the JDK versions since it's a simple fix.
>
> Kind regards
> --
> *Nuwan Jayawardene*
> Assistant Lecturer, Informatics Institute of Technology (IIT).
> Research Assistant, University of Moratuwa
> Tel - +94 71 181 3299
> https://www.linkedin.com/m/in/nuwanjaya
>
>
>