[GitHub] [ignite] kukushal commented on a change in pull request #7844: IGNITE-12823 .NET: Fix service method calls with typed array args

[GitBox <gi...@apache.org>]

kukushal commented on a change in pull request #7844:
URL: https://github.com/apache/ignite/pull/7844#discussion_r431064315



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/services/PlatformServices.java
##########
@@ -581,6 +582,26 @@ public Object invoke(String mthdName, boolean srvKeepBinary, Object[] args)
 
                 Method mtd = getMethod(serviceClass, mthdName, args);
 
+                // Convert Object[] to T[] when required:
+                // Ignite loses array item types when passing arguments through GridServiceProxy.
+                for (int i = 0; i < args.length; i++) {

Review comment:
       IgniteServices has a "keep binary" flag that makes the server side NOT to deserialize parameters, thus, allowing NOT having Java classes on the server. You need to do this block only if the "keep binary" flag is not set. Otherwise it will do that Array.newInstance thing even when "keep binary = true". 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org