You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2010/10/23 19:48:43 UTC

[jira] Created: (MYFACES-2957) Use maven shade plugin to handle myfaces-impl-ee6 module

Use maven shade plugin to handle myfaces-impl-ee6 module
--------------------------------------------------------

                 Key: MYFACES-2957
                 URL: https://issues.apache.org/jira/browse/MYFACES-2957
             Project: MyFaces Core
          Issue Type: Improvement
          Components: build process
    Affects Versions: 2.0.2
            Reporter: Leonardo Uribe
            Assignee: Leonardo Uribe


Right now, we need a special profile to load myfaces-impl module on eclipse, because myfaces-impl-ee6 module is added on source folders. 

Investigating alternative ways to do it, I notice that we can use maven shade plugin to handle myfaces-impl-ee6 module and prevent this condition. The advantage of this plugin is myfaces-impl-ee6 module is this is not added as a source path, but it updates binary and source jar properly.

The only disadvantage is maven-shade-plugin does not play well with felix OSGI bundle plugin. We can't control the execution order of maven plugins, due to http://jira.codehaus.org/browse/MNG-2258, and in this case, bundle plugin is executed before shade plugin.

There is a workaround for this one and is unpack myfaces-impl-ee6 .class files, so it will be taken into account by bundle plugin. Then, maven shade plugin detect the duplicate but does not stop working, replacing the class with the shaded one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (MYFACES-2957) Use maven shade plugin to handle myfaces-impl-ee6 module

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-2957.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.3-SNAPSHOT

> Use maven shade plugin to handle myfaces-impl-ee6 module
> --------------------------------------------------------
>
>                 Key: MYFACES-2957
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2957
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: build process
>    Affects Versions: 2.0.2
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.3-SNAPSHOT
>
>
> Right now, we need a special profile to load myfaces-impl module on eclipse, because myfaces-impl-ee6 module is added on source folders. 
> Investigating alternative ways to do it, I notice that we can use maven shade plugin to handle myfaces-impl-ee6 module and prevent this condition. The advantage of this plugin is myfaces-impl-ee6 module is this is not added as a source path, but it updates binary and source jar properly.
> The only disadvantage is maven-shade-plugin does not play well with felix OSGI bundle plugin. We can't control the execution order of maven plugins, due to http://jira.codehaus.org/browse/MNG-2258, and in this case, bundle plugin is executed before shade plugin.
> There is a workaround for this one and is unpack myfaces-impl-ee6 .class files, so it will be taken into account by bundle plugin. Then, maven shade plugin detect the duplicate but does not stop working, replacing the class with the shaded one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.