You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by jean-frederic clere <jf...@fujitsu-siemens.com> on 2001/11/21 17:28:23 UTC
[PATCH] Check the mpm exists when using --with-mpm=MPM
Jeff Trawick wrote:
>
> jean-frederic clere <jf...@fujitsu-siemens.com> writes:
>
> > What should I use now? worker or perchild
>
> As it says in CHANGES...
>
> *) The threaded MPM for Unix has been removed. Use the worker
> MPM instead. [various]
>
> > Would it be possible to check the given parameter --with-mpm against the
> > supported mpm implementations?
>
> Sure, that sounds very nice. How about posting a patch to
> dev@httpd.apache.org :) ?
Done :))
>
> Best wishes,
>
> Jeff
>
> --
> Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
> http://www.geocities.com/SiliconValley/Park/9289/
> Born in Roswell... married an alien...
Re: [PATCH] Check the mpm exists when using --with-mpm=MPM
Posted by Justin Erenkrantz <je...@ebuilt.com>.
On Wed, Nov 21, 2001 at 11:40:56AM -0500, Jeff Trawick wrote:
> (maybe AC_MSG_ERROR() bails out; I dunno)
It does. -- justin
Re: [PATCH] Check the mpm exists when using --with-mpm=MPM
Posted by jean-frederic clere <jf...@fujitsu-siemens.com>.
Jeff Trawick wrote:
>
> jean-frederic clere <jf...@fujitsu-siemens.com> writes:
>
> > ===================================================================
> > RCS file: /home/cvs/apache/httpd-2.0/server/mpm/config.m4,v
> > retrieving revision 1.39
> > diff -u -r1.39 config.m4
> > --- ./server/mpm/config.m4 2001/11/19 18:07:28 1.39
> > +++ ./server/mpm/config.m4 2001/11/21 16:24:35
> > @@ -22,6 +22,9 @@
> > apache_cv_mpm=prefork
> > fi
> > fi
> > +if test ! -f "server/mpm/$apache_cv_mpm/mpm.h"; then
> > + AC_MSG_ERROR(the selected mpm: $apache_cv_mpm is not supported)
> > +fi
> >
> > APACHE_FAST_OUTPUT(server/mpm/Makefile)
> >
>
> don't we need an "exit 1" in there? otherwise, the user may miss the
> message and still get way into make where mpm_common.c (just a guess)
> won't compile because it can't find mpm.h
>
> (maybe AC_MSG_ERROR() bails out; I dunno)
It does.
> --
> Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
> http://www.geocities.com/SiliconValley/Park/9289/
> Born in Roswell... married an alien...
Re: [PATCH] Check the mpm exists when using --with-mpm=MPM
Posted by Jeff Trawick <tr...@attglobal.net>.
jean-frederic clere <jf...@fujitsu-siemens.com> writes:
> ===================================================================
> RCS file: /home/cvs/apache/httpd-2.0/server/mpm/config.m4,v
> retrieving revision 1.39
> diff -u -r1.39 config.m4
> --- ./server/mpm/config.m4 2001/11/19 18:07:28 1.39
> +++ ./server/mpm/config.m4 2001/11/21 16:24:35
> @@ -22,6 +22,9 @@
> apache_cv_mpm=prefork
> fi
> fi
> +if test ! -f "server/mpm/$apache_cv_mpm/mpm.h"; then
> + AC_MSG_ERROR(the selected mpm: $apache_cv_mpm is not supported)
> +fi
>
> APACHE_FAST_OUTPUT(server/mpm/Makefile)
>
don't we need an "exit 1" in there? otherwise, the user may miss the
message and still get way into make where mpm_common.c (just a guess)
won't compile because it can't find mpm.h
(maybe AC_MSG_ERROR() bails out; I dunno)
--
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...