You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:57:05 UTC

[GitHub] [kafka] socutes opened a new pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

socutes opened a new pull request #10876:
URL: https://github.com/apache/kafka/pull/10876


   See KIP-740 – for the TaskMetadata class, we need to:
   
   Deprecate the TaskMetadata#getTaskId method
   "Remove" the deprecated TaskMetadata#taskId method, then re-add a taskId() API that returns a TaskId instead of a String
   Remove the deprecated constructor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] socutes closed pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

Posted by GitBox <gi...@apache.org>.

socutes closed pull request #10876:
URL: https://github.com/apache/kafka/pull/10876


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ableegoldman commented on pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

Posted by GitBox <gi...@apache.org>.

ableegoldman commented on pull request #10876:
URL: https://github.com/apache/kafka/pull/10876#issuecomment-861126045


   Thanks for the PR, but @jlprat is correct. Unfortunately this ticket will need to wait for the 4.0 release, which as of this time has not yet even been announced. You can work on this when that time does come around, but for now I recommend looking for another ticket that can actually be worked on right away. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] socutes commented on pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

Posted by GitBox <gi...@apache.org>.

socutes commented on pull request #10876:
URL: https://github.com/apache/kafka/pull/10876#issuecomment-860171343


   @ableegoldman please help to review this patch!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jlprat commented on pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

Posted by GitBox <gi...@apache.org>.

jlprat commented on pull request #10876:
URL: https://github.com/apache/kafka/pull/10876#issuecomment-860180512


   Hi @socutes, thanks for the PR. However, I would say it comes a bit early. Version 3.0.0 is not yet released, actually we are currently working towards that release. So any PR merged in Trunk would land in 3.0.0.
   If you look at the Jira issue, you'll see that target release is 4.0.0.
   
   If you are looking for issues to contribute, I'll say it's best if you pick the ones whose 'fix for' field is not 4.0.0.
   
   Thanks again!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org