[GitHub] [dubbo] TrueAbc commented on a diff in pull request #10474: add dubbo wire protocol for pu server

[GitBox <gi...@apache.org>]

TrueAbc commented on code in PR #10474:
URL: https://github.com/apache/dubbo/pull/10474#discussion_r950663513


##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyPortUnificationServerHandler.java:
##########
@@ -49,16 +53,18 @@ public class NettyPortUnificationServerHandler extends ByteToMessageDecoder {
     private final ChannelHandler handler;
     private final boolean detectSsl;
     private final List<WireProtocol> protocols;
+    private Map<String, Channel> dubboChannels;

Review Comment:
   dubboChannels can make pu server manage channels defined in dubbo, and this ablity is needed by some test cases. So I delete DefaultChannelGroup and choose dubboChannels 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org