[jira] [Commented] (BEAM-3373) Add serviceEndpoint parameter to KinesisIO

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315488#comment-16315488 ] 

ASF GitHub Bot commented on BEAM-3373:
--------------------------------------

iemejia opened a new pull request #4358: [BEAM-3373] Add serviceEndpoint parameter to KinesisIO
URL: https://github.com/apache/beam/pull/4358
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add serviceEndpoint parameter to KinesisIO
> ------------------------------------------
>
>                 Key: BEAM-3373
>                 URL: https://issues.apache.org/jira/browse/BEAM-3373
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Trivial
>
> KinesisClient can be instantiated with a different serviceEndpoint to the official Amazon one. This allows users to test KinesisIO locally by overwriting the endpointUrl and pointing to an emulator like https://github.com/localstack/localstack or https://github.com/mhart/kinesalite



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)