You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by an...@apache.org on 2016/03/21 11:23:21 UTC

[12/17] libcloud git commit: implements delete_record method

implements delete_record method


Project: http://git-wip-us.apache.org/repos/asf/libcloud/repo
Commit: http://git-wip-us.apache.org/repos/asf/libcloud/commit/6ce9ff6b
Tree: http://git-wip-us.apache.org/repos/asf/libcloud/tree/6ce9ff6b
Diff: http://git-wip-us.apache.org/repos/asf/libcloud/diff/6ce9ff6b

Branch: refs/heads/trunk
Commit: 6ce9ff6b028e3ffa692d0ea5097cdc0cd696bd27
Parents: 0f278d9
Author: lostbird <lostbird@lostbird.(none)>
Authored: Tue Feb 23 11:33:55 2016 +0100
Committer: anthony-shaw <an...@gmail.com>
Committed: Mon Mar 21 21:20:31 2016 +1100

----------------------------------------------------------------------
 libcloud/dns/drivers/nsone.py | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/libcloud/blob/6ce9ff6b/libcloud/dns/drivers/nsone.py
----------------------------------------------------------------------
diff --git a/libcloud/dns/drivers/nsone.py b/libcloud/dns/drivers/nsone.py
index 4e54491..69a38f4 100644
--- a/libcloud/dns/drivers/nsone.py
+++ b/libcloud/dns/drivers/nsone.py
@@ -142,7 +142,16 @@ class NsOneDNSDriver(DNSDriver):
         return record
 
     def delete_record(self, record):
-        pass
+        action = '/v1/zones/%s/%s/%s' % (record.zone.domain, record.name, record.type)
+        try:
+            response = self.connection.request(action=action, method='DELETE')
+        except NsOneException, e:
+            if e.message == 'record not found':
+                raise RecordDoesNotExistError(value=e.message, driver=self, record_id=record.id)
+            else:
+                raise e
+
+        return response.status == httplib.OK
 
     def create_record(self, name, zone, type, data, extra=None):
         action = '/v1/zones/%s/%s/%s' % (zone.domain, zone.domain, type)
@@ -150,13 +159,12 @@ class NsOneDNSDriver(DNSDriver):
             "answers": [
                 {
                     "answer": [
-                        10,
                         data
                     ], }
             ],
             "type": type,
             "domain": zone.domain,
-            "zone": zone
+            "zone": zone.domain
         }
 
         if extra is not None: