You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/24 15:27:45 UTC
[GitHub] [tvm] ekalda commented on a change in pull request #10725: [microNPU] Add a pass to move allocate nodes to the outer scope
ekalda commented on a change in pull request #10725:
URL: https://github.com/apache/tvm/pull/10725#discussion_r834394558
##########
File path: src/tir/contrib/ethosu/passes.cc
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tir/contrib/ethosu/passes.cc
+ *
+ * \brief Passes used in TIR lowering for the microNPU compiler.
+ */
+#include <tvm/tir/builtin.h>
+#include <tvm/tir/function.h>
+#include <tvm/tir/stmt_functor.h>
+#include <tvm/tir/transform.h>
+
+namespace tvm {
+namespace tir {
+namespace contrib {
+namespace ethosu {
+
+/*!
+ * \brief This mutator moves allocates to the top of the body of the main
+ * function.
+ *
+ * Note: This pass can currently only be run in conjunction with the
+ * LowerToTIR() pass as it expects a single primitive function called
+ * "main" that is being offloaded to the NPU.
+ *
+ * For example,
+ * allocate {
+ * extern_call(...)
+ * allocate {
+ * Before: extern_call(...)
+ * }
+ * }
+ *
+ * allocate {
+ * allocate {
+ * extern_call(...)
+ * After: extern_call(...)
+ * }
+ * }
Review comment:
Nit: I think it would be clearer if "Before" and "After" were also hoisted to the top of their corresponding blocks
##########
File path: src/tir/contrib/ethosu/passes.cc
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tir/contrib/ethosu/passes.cc
+ *
+ * \brief Passes used in TIR lowering for the microNPU compiler.
+ */
+#include <tvm/tir/builtin.h>
+#include <tvm/tir/function.h>
+#include <tvm/tir/stmt_functor.h>
+#include <tvm/tir/transform.h>
+
+namespace tvm {
+namespace tir {
+namespace contrib {
+namespace ethosu {
+
+/*!
+ * \brief This mutator moves allocates to the top of the body of the main
+ * function.
+ *
+ * Note: This pass can currently only be run in conjunction with the
+ * LowerToTIR() pass as it expects a single primitive function called
+ * "main" that is being offloaded to the NPU.
+ *
+ * For example,
+ * allocate {
+ * extern_call(...)
+ * allocate {
+ * Before: extern_call(...)
+ * }
+ * }
+ *
+ * allocate {
+ * allocate {
+ * extern_call(...)
+ * After: extern_call(...)
+ * }
+ * }
+ */
+class HoistAllocatesMutator : public StmtExprMutator {
+ public:
+ HoistAllocatesMutator() {}
+
+ PrimFunc operator()(PrimFunc main_func) {
+ Stmt new_main_func_body = this->VisitStmt(main_func->body);
+
+ // Write all allocates that were removed in reverse order
+ for (auto it = allocates_.rbegin(); it != allocates_.rend(); it++) {
+ Allocate current_alloc = *it;
+ if (it != allocates_.rbegin()) {
+ new_main_func_body = SeqStmt({new_main_func_body});
+ }
+ new_main_func_body =
+ Allocate(current_alloc->buffer_var, current_alloc->dtype, current_alloc->extents,
+ current_alloc->condition, new_main_func_body, current_alloc->annotations,
+ current_alloc->span);
+ }
+
+ PrimFunc new_main_func =
+ PrimFunc(main_func->params, new_main_func_body, main_func->ret_type, main_func->buffer_map,
+ main_func->preflattened_buffer_map, main_func->attrs);
+ return new_main_func;
+ }
+
+ private:
+ Stmt VisitStmt_(const AllocateNode* op) override {
+ allocates_.push_back(GetRef<Allocate>(op));
+
+ // Skip the allocate node itself
+ const auto* seq = op->body.as<SeqStmtNode>();
+ ICHECK(seq) << "Expected a sequence statement but got " << op->body->GetTypeKey() << ".";
Review comment:
Is there always a sequence statement after an allocate node?
##########
File path: src/tir/contrib/ethosu/passes.cc
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file tir/contrib/ethosu/passes.cc
+ *
+ * \brief Passes used in TIR lowering for the microNPU compiler.
+ */
+#include <tvm/tir/builtin.h>
+#include <tvm/tir/function.h>
+#include <tvm/tir/stmt_functor.h>
+#include <tvm/tir/transform.h>
+
+namespace tvm {
+namespace tir {
+namespace contrib {
+namespace ethosu {
+
+/*!
+ * \brief This mutator moves allocates to the top of the body of the main
+ * function.
+ *
+ * Note: This pass can currently only be run in conjunction with the
+ * LowerToTIR() pass as it expects a single primitive function called
+ * "main" that is being offloaded to the NPU.
+ *
+ * For example,
+ * allocate {
+ * extern_call(...)
+ * allocate {
+ * Before: extern_call(...)
+ * }
+ * }
+ *
+ * allocate {
+ * allocate {
+ * extern_call(...)
+ * After: extern_call(...)
+ * }
+ * }
+ */
+class HoistAllocatesMutator : public StmtExprMutator {
+ public:
+ HoistAllocatesMutator() {}
+
+ PrimFunc operator()(PrimFunc main_func) {
+ Stmt new_main_func_body = this->VisitStmt(main_func->body);
+
+ // Write all allocates that were removed in reverse order
+ for (auto it = allocates_.rbegin(); it != allocates_.rend(); it++) {
+ Allocate current_alloc = *it;
+ if (it != allocates_.rbegin()) {
+ new_main_func_body = SeqStmt({new_main_func_body});
+ }
+ new_main_func_body =
+ Allocate(current_alloc->buffer_var, current_alloc->dtype, current_alloc->extents,
+ current_alloc->condition, new_main_func_body, current_alloc->annotations,
+ current_alloc->span);
+ }
+
+ PrimFunc new_main_func =
+ PrimFunc(main_func->params, new_main_func_body, main_func->ret_type, main_func->buffer_map,
+ main_func->preflattened_buffer_map, main_func->attrs);
+ return new_main_func;
+ }
+
+ private:
+ Stmt VisitStmt_(const AllocateNode* op) override {
+ allocates_.push_back(GetRef<Allocate>(op));
+
+ // Skip the allocate node itself
+ const auto* seq = op->body.as<SeqStmtNode>();
+ ICHECK(seq) << "Expected a sequence statement but got " << op->body->GetTypeKey() << ".";
+
+ // Traverse the allocate body recursively and flatten
+ Array<Stmt> new_stmts;
+ new_stmts.reserve(seq->seq.size());
+ for (const Stmt& old_stmt : seq->seq) {
+ new_stmts.push_back(VisitStmt(old_stmt));
+ }
+ return SeqStmt::Flatten(new_stmts);
Review comment:
For enlightenment, what does flattening mean in that context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org