You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "frankliee (via GitHub)" <gi...@apache.org> on 2023/04/10 12:18:50 UTC

[GitHub] [iceberg] frankliee commented on a diff in pull request #7310: Hive: Clean up expired metastore clients

frankliee commented on code in PR #7310:
URL: https://github.com/apache/iceberg/pull/7310#discussion_r1161675630


##########
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##########
@@ -147,4 +147,8 @@ private void release(C client) {
   public int poolSize() {
     return poolSize;
   }
+
+  public boolean isClosed() {

Review Comment:
   ClientPoolImpl and UT are in different packages, so package-private is not enough.
   But I will add VisibleForTesting.
   
   cc @chenjunjiedada 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org