You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/09 14:43:41 UTC

[GitHub] [doris] xy720 opened a new pull request, #15748: [Enhancement] Add a switch for users to force using alias name in group by and having clause

xy720 opened a new pull request, #15748:
URL: https://github.com/apache/doris/pull/15748

   # Proposed changes
   
   Issue Number: close #15747 
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yangzhg commented on pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by GitBox <gi...@apache.org>.
yangzhg commented on PR #15748:
URL: https://github.com/apache/doris/pull/15748#issuecomment-1376596005

   add a regression test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] xy720 commented on pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by GitBox <gi...@apache.org>.
xy720 commented on PR #15748:
URL: https://github.com/apache/doris/pull/15748#issuecomment-1380233483

   Update docs and add regression test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by github-actions.
github-actions[bot] commented on PR #15748:
URL: https://github.com/apache/doris/pull/15748#issuecomment-1409920053

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by GitBox <gi...@apache.org>.
morningman commented on PR #15748:
URL: https://github.com/apache/doris/pull/15748#issuecomment-1376601486

   Please update variables.md doc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15748:
URL: https://github.com/apache/doris/pull/15748#issuecomment-1375784201

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 36.59 seconds
    load time: 492 seconds
    storage size: 17122181433 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230109152006_clickbench_pr_76290.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman commented on a diff in pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #15748:
URL: https://github.com/apache/doris/pull/15748#discussion_r1090164777


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java:
##########
@@ -1266,7 +1272,8 @@ private void analyzeAggregation(Analyzer analyzer) throws AnalysisException {
                 groupingInfo.buildRepeat(groupingExprs, groupByClause.getGroupingSetList());
             }
 
-            substituteOrdinalsAliases(groupingExprs, "GROUP BY", analyzer, false);
+            boolean aliasFirst = ConnectContext.get().getSessionVariable().isGroupByAndHavingUseAliasFirst();

Review Comment:
   The `ConnectContext.get()` may be null when replaying edit log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by github-actions.
github-actions[bot] commented on PR #15748:
URL: https://github.com/apache/doris/pull/15748#issuecomment-1409920007

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #15748: [Enhancement](grouping) Add a switch for users to force using alias name in group by and having clause

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #15748:
URL: https://github.com/apache/doris/pull/15748


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org