You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/15 12:02:59 UTC
[GitHub] [flink] nielsbasjes opened a new pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
nielsbasjes opened a new pull request #12907:
URL: https://github.com/apache/flink/pull/12907
## What is the purpose of the change
Make the build output more human readable for the developers van various situations.
## Brief change log
Add or change the `<name>` of each maven module (i.e. in every pom.xml)
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
The simplest way to test is by doing a `mvn clean` and verify the list of names at the end looks good.
Also looking at the change set verify that the names for each module are correct.
In some exceptional cases I made the name reflect a bit more the purpose like in the case of
`flink-examples/flink-examples-build-helper` where the description indicates `This is a utility module for building example jars to be used in flink-dist.` so I named it `Flink : Examples : Dist : `
Fun fact: I noticed that the ordering of the modules during the build is changed a lot by maven because apparently the ordering of the modules in the pom.xml does not meet the configured dependencies between the modules. So maven reorders the build by itself.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung merged pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
KurtYoung merged pull request #12907:
URL: https://github.com/apache/flink/pull/12907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nielsbasjes edited a comment on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
nielsbasjes edited a comment on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658728948
Note that all `<packaging>pom</packaging>` modules have a name that ends with `<space>:<space>` because that makes the ordering in the Maven overview in IntelliJ better.
Also note that the naming convention I show here is based upon my own preference: what I find easy to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658734085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535",
"triggerID" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bcd598e98411c31d577e8c1ee09c0468decd005a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658734085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535",
"triggerID" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"triggerType" : "PUSH"
}, {
"hash" : "b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bcd598e98411c31d577e8c1ee09c0468decd005a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535)
* b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nielsbasjes commented on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658728948
Note that all '<packaging>pom</packaging>' modules have a name that ends with `<space>:<space>` because that makes the ordering in the Maven overview in IntelliJ better.
Also note that the naming convention I show here is based upon my own preference: what I find easy to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658734085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535",
"triggerID" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"triggerType" : "PUSH"
}, {
"hash" : "b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4673",
"triggerID" : "b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4673)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658731246
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bcd598e98411c31d577e8c1ee09c0468decd005a (Wed Jul 15 12:11:46 UTC 2020)
**Warnings:**
* **187 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18607).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658734085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535",
"triggerID" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bcd598e98411c31d577e8c1ee09c0468decd005a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nielsbasjes commented on a change in pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on a change in pull request #12907:
URL: https://github.com/apache/flink/pull/12907#discussion_r455066935
##########
File path: flink-examples/flink-examples-build-helper/flink-examples-streaming-gcp-pubsub/pom.xml
##########
@@ -29,7 +29,7 @@ under the License.
</parent>
<artifactId>flink-examples-streaming-gcp-pubsub_${scala.binary.version}</artifactId>
- <name>flink-examples-streaming-gcp-pubsub</name>
+ <name>Flink : Examples : Dist : Streaming Google PubSub</name>
Review comment:
Yes, can be. I had doubts about this one. The artifact name is build helper yet the purpose is making it available in the dist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658734085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535",
"triggerID" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"triggerType" : "PUSH"
}, {
"hash" : "b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4673",
"triggerID" : "b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bcd598e98411c31d577e8c1ee09c0468decd005a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4535)
* b4f6dd1235fc84ecb9c9a4a82bef6f5c7a84df25 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4673)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-658734085
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bcd598e98411c31d577e8c1ee09c0468decd005a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bcd598e98411c31d577e8c1ee09c0468decd005a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on pull request #12907:
URL: https://github.com/apache/flink/pull/12907#issuecomment-662224367
@nielsbasjes Thanks for the update, I will merge this once tests passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nielsbasjes commented on a change in pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on a change in pull request #12907:
URL: https://github.com/apache/flink/pull/12907#discussion_r457929951
##########
File path: flink-examples/flink-examples-build-helper/flink-examples-streaming-gcp-pubsub/pom.xml
##########
@@ -29,7 +29,7 @@ under the License.
</parent>
<artifactId>flink-examples-streaming-gcp-pubsub_${scala.binary.version}</artifactId>
- <name>flink-examples-streaming-gcp-pubsub</name>
+ <name>Flink : Examples : Dist : Streaming Google PubSub</name>
Review comment:
I personally would rename this to something like "dist helper" or "dist examples" but that is a separate change if desired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] nielsbasjes commented on a change in pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on a change in pull request #12907:
URL: https://github.com/apache/flink/pull/12907#discussion_r457928304
##########
File path: flink-examples/flink-examples-build-helper/flink-examples-streaming-gcp-pubsub/pom.xml
##########
@@ -29,7 +29,7 @@ under the License.
</parent>
<artifactId>flink-examples-streaming-gcp-pubsub_${scala.binary.version}</artifactId>
- <name>flink-examples-streaming-gcp-pubsub</name>
+ <name>Flink : Examples : Dist : Streaming Google PubSub</name>
Review comment:
For now I made it consistent with the module artifact name : "Build Helper".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on a change in pull request #12907: [FLINK-18607][build] Give the maven module a human readable name
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #12907:
URL: https://github.com/apache/flink/pull/12907#discussion_r455029781
##########
File path: flink-examples/flink-examples-build-helper/flink-examples-streaming-gcp-pubsub/pom.xml
##########
@@ -29,7 +29,7 @@ under the License.
</parent>
<artifactId>flink-examples-streaming-gcp-pubsub_${scala.binary.version}</artifactId>
- <name>flink-examples-streaming-gcp-pubsub</name>
+ <name>Flink : Examples : Dist : Streaming Google PubSub</name>
Review comment:
Dist -> Helper?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org