You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by di...@apache.org on 2006/03/20 00:57:13 UTC

svn commit: r387075 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java

Author: dion
Date: Sun Mar 19 15:57:12 2006
New Revision: 387075

URL: http://svn.apache.org/viewcvs?rev=387075&view=rev
Log:
make variables that aren't changeable private - pmd report

Modified:
    jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java

Modified: jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java?rev=387075&r1=387074&r2=387075&view=diff
==============================================================================
--- jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java (original)
+++ jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java Sun Mar 19 15:57:12 2006
@@ -47,13 +47,13 @@
     /**
      * The objects to iterate.
      */
-    private Object array;
+    private final Object array;
 
     /**
      * The current position and size in the array.
      */
     private int pos;
-    private int size;
+    private final int size;
 
     /**
      * Creates a new iterator instance for the specified array.



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: svn commit: r387075 - /jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/ArrayIterator.java

Posted by Rahul Akolkar <ra...@gmail.com>.
On 3/19/06, dion@apache.org <di...@apache.org> wrote:
> Author: dion
> Date: Sun Mar 19 15:57:12 2006
> New Revision: 387075
>
> URL: http://svn.apache.org/viewcvs?rev=387075&view=rev
> Log:
> make variables that aren't changeable private - pmd report
>
<snip/>

s/private/final, but we probably don't care enough to propedit the
logs (saw a bunch of commits with the same typo).

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org