You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/10/24 19:40:57 UTC
[GitHub] [avro] MickJermsurawong opened a new pull request #969: AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream
MickJermsurawong opened a new pull request #969:
URL: https://github.com/apache/avro/pull/969
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the https://issues.apache.org/jira/browse/AVRO-2944
### Tests
- [ ] My PR adds the following one unit test to first illustrate failure
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #969: AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #969:
URL: https://github.com/apache/avro/pull/969#issuecomment-720328892
Cherry-picked to [branch-1.10](https://github.com/apache/avro/commit/56b47fcde6f5d636b3ebaf4a7e238f327b06e66b)! Thanks again for this fix!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] noslowerdna commented on pull request #969: AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream
Posted by GitBox <gi...@apache.org>.
noslowerdna commented on pull request #969:
URL: https://github.com/apache/avro/pull/969#issuecomment-771243207
@MickJermsurawong / @RyanSkraba I [asked a question](https://issues.apache.org/jira/browse/AVRO-2944?focusedCommentId=17276713&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17276713) on the JIRA, curious if this fix could be improved to cover the `read` returning -1 unexpectedly as the issue description indicates it ought to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] MickJermsurawong commented on pull request #969: AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream
Posted by GitBox <gi...@apache.org>.
MickJermsurawong commented on pull request #969:
URL: https://github.com/apache/avro/pull/969#issuecomment-716665845
The CI failure seems unrelated to the change in this PR.
For java 8:
```
Trevni Specification ............................... FAILURE [ 3.264 s]
```
For java 11:
```
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- beberlei/composer-monorepo-plugin[v0.12, ..., v0.12.1] require composer-plugin-api ^1.0 -> found composer-plugin-api[2.0.0] but it does not match the constraint.
- Root composer.json requires beberlei/composer-monorepo-plugin ^0.12 -> satisfiable by beberlei/composer-monorepo-plugin[v0.12, v0.12.1].
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] noslowerdna commented on pull request #969: AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream
Posted by GitBox <gi...@apache.org>.
noslowerdna commented on pull request #969:
URL: https://github.com/apache/avro/pull/969#issuecomment-771243207
@MickJermsurawong / @RyanSkraba I [asked a question](https://issues.apache.org/jira/browse/AVRO-2944?focusedCommentId=17276713&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17276713) on the JIRA, curious if this fix could be improved to cover the `read` returning -1 unexpectedly as the issue description indicates it ought to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #969: AVRO-2944: Fix read pointer in java reader to avoid hang on partial read input stream
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #969:
URL: https://github.com/apache/avro/pull/969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org