You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/04/16 00:11:14 UTC
[jira] Created: (ZOOKEEPER-376) ant test target re-compiles cppunit
code every time
ant test target re-compiles cppunit code every time
---------------------------------------------------
Key: ZOOKEEPER-376
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
Project: Zookeeper
Issue Type: Bug
Components: build, c client
Affects Versions: 3.2.0
Reporter: Patrick Hunt
Assignee: Giridharan Kesavan
Priority: Minor
Fix For: 3.2.0
Giri, can you take a look at this:
1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-376) ant test target re-compiles
cppunit code every time
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707388#action_12707388 ]
Hudson commented on ZOOKEEPER-376:
----------------------------------
Integrated in ZooKeeper-trunk #303 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/303/])
. ant test target re-compiles cppunit code every time (phunt via mahadev)
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-376) ant test target re-compiles cppunit
code every time
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-376:
-----------------------------------
Status: Patch Available (was: Open)
submitting patch - expect it to fail due to build change, no tests were modified.
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-376) ant test target re-compiles cppunit
code every time
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-376:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
thats good.. I just committed this. thanks pat.
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-376) ant test target re-compiles
cppunit code every time
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706735#action_12706735 ]
Patrick Hunt commented on ZOOKEEPER-376:
----------------------------------------
the makefile has targets/dependencies to handle changes to any of those files. if it notices a change it will
run the appropriate script to update. See the Makefile - look for makefile.am/makefile/configure.ac/etc... I tried
a number of things (like touching those files and retrying the build) and it seemed to handle it appropriately.
Give it a try yourself.
It shouldn't be an issue but I don't think you are correct re the patch process. afaik the build/patch process
always starts "from scratch" - ie with a clean checkout into an empty directory.
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-376) ant test target re-compiles
cppunit code every time
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705924#action_12705924 ]
Mahadev konar commented on ZOOKEEPER-376:
-----------------------------------------
what will happen if I change Makefile.am and the old Makefile still exist? Will it just run the old makefile or regenrate the Makefile again? Also, what happens if I change the configure.ac and the old Makefile still exists?
These are valid concerns since the patch process will just apply the patch (incase we make a change to just Makefile.am) and since the Makefile will already exist (because of the last build process) we have to make sure that makefile is regenerated...
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-376) ant test target re-compiles
cppunit code every time
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-376:
--------------------------------------
Assignee: Patrick Hunt (was: Giridharan Kesavan)
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-376) ant test target re-compiles
cppunit code every time
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704891#action_12704891 ]
Hadoop QA commented on ZOOKEEPER-376:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406976/ZOOKEEPER-376.patch
against trunk revision 769885.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/57/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/57/console
This message is automatically generated.
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-376) ant test target re-compiles cppunit
code every time
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-376:
-----------------------------------
Attachment: ZOOKEEPER-376.patch
I've updated the cppunit build.xml based on my following understanding
of how autotools works:
1. If we have a Makefile it will handle up-to-date check and also
regenerate the configure script if missing. (done)
2. If we don't have a Makefile use the configure script to
regenerate it. (done)
3. If we don't have a Makefile nor a configure script then it's
last resort and run autoreconf, then configure (done)
> ant test target re-compiles cppunit code every time
> ---------------------------------------------------
>
> Key: ZOOKEEPER-376
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-376
> Project: Zookeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Minor
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-376.patch
>
>
> Giri, can you take a look at this:
> 1) looks like autoreconf is always run, which means that a re-configure/re-make is run each time the tests are run using ant
> 2) tabs were introduced to the build when cppunit changes were made, please only use spaces (would be great if you could fix this too -- hard to read in my editor)
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.