You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yu-iskw <gi...@git.apache.org> on 2015/03/27 05:14:13 UTC
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
GitHub user yu-iskw opened a pull request:
https://github.com/apache/spark/pull/5222
[SPARK-6341][mllib] Upgrade breeze from 0.11.1 to 0.11.2
There are any bugs of breeze's SparseVector at 0.11.1. You know, Spark 1.3 depends on breeze 0.11.1. So I think we should upgrade it to 0.11.2.
https://issues.apache.org/jira/browse/SPARK-6341
And thanks you for your great cooperation, David Hall(@dlwh)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yu-iskw/spark upgrade-breeze
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5222
----
commit ad8a688e980d7c2cbd5d16cbc146f7fb85934cbe
Author: Yu ISHIKAWA <yu...@gmail.com>
Date: 2015-03-27T04:04:01Z
Upgrade breeze from 0.11.1 to 0.11.2 because of a bug of SparseVector.
Thanks you for your great cooperation, David Hall(@dlwh)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-86834834
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29281/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by yu-iskw <gi...@git.apache.org>.
GitHub user yu-iskw reopened a pull request:
https://github.com/apache/spark/pull/5222
[SPARK-6341][mllib] Upgrade breeze from 0.11.1 to 0.11.2
There are any bugs of breeze's SparseVector at 0.11.1. You know, Spark 1.3 depends on breeze 0.11.1. So I think we should upgrade it to 0.11.2.
https://issues.apache.org/jira/browse/SPARK-6341
And thanks you for your great cooperation, David Hall(@dlwh)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yu-iskw/spark upgrade-breeze
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5222.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5222
----
commit ad8a688e980d7c2cbd5d16cbc146f7fb85934cbe
Author: Yu ISHIKAWA <yu...@gmail.com>
Date: 2015-03-27T04:04:01Z
Upgrade breeze from 0.11.1 to 0.11.2 because of a bug of SparseVector.
Thanks you for your great cooperation, David Hall(@dlwh)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw closed the pull request at:
https://github.com/apache/spark/pull/5222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-86928260
@yu-iskw It looks like there was some delay in the git sync or something. You can see that after your last message, the commits do appear in `master` and `branch-1.3`, so I think you can close it again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-86834829
[Test build #29281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29281/consoleFull) for PR 5222 at commit [`ad8a688`](https://github.com/apache/spark/commit/ad8a688e980d7c2cbd5d16cbc146f7fb85934cbe).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-86852093
LGTM. Merged into master and branch-1.3. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-86856462
@mengxr sorry for re-open this PR. Have this PR been merged? I couldn't see the commit log in the master branch. https://github.com/apache/spark/commits/master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-86812100
[Test build #29281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29281/consoleFull) for PR 5222 at commit [`ad8a688`](https://github.com/apache/spark/commit/ad8a688e980d7c2cbd5d16cbc146f7fb85934cbe).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw closed the pull request at:
https://github.com/apache/spark/pull/5222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-86852400
@mengxr Thank you for merging it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-87004775
Yes, github got ddos last night.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6341][mllib] Upgrade breeze from 0.11.1...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/5222#issuecomment-87589402
@mengxr and @srowen, alright. There was some delay because github was attacked. I'm closing this PR. Thank you for your helping.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org