You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by rp...@apache.org on 2008/02/24 15:39:36 UTC
svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c
Author: rpluem
Date: Sun Feb 24 06:39:34 2008
New Revision: 630625
URL: http://svn.apache.org/viewvc?rev=630625&view=rev
Log:
* Fix compiler warning as written is signed.
Noted by: nikke
Modified:
apr/apr-util/trunk/buckets/apr_brigade.c
Modified: apr/apr-util/trunk/buckets/apr_brigade.c
URL: http://svn.apache.org/viewvc/apr/apr-util/trunk/buckets/apr_brigade.c?rev=630625&r1=630624&r2=630625&view=diff
==============================================================================
--- apr/apr-util/trunk/buckets/apr_brigade.c (original)
+++ apr/apr-util/trunk/buckets/apr_brigade.c Sun Feb 24 06:39:34 2008
@@ -653,7 +653,7 @@
/* the cast, in order of appearance */
struct brigade_vprintf_data_t vd;
char buf[APR_BUCKET_BUFF_SIZE];
- apr_size_t written;
+ int written;
vd.vbuff.curpos = buf;
vd.vbuff.endpos = buf + APR_BUCKET_BUFF_SIZE;
Re: svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c
Posted by Ruediger Pluem <rp...@apache.org>.
On 02/24/2008 06:13 PM, William A. Rowe, Jr. wrote:
> rpluem@apache.org wrote:
>> - apr_size_t written;
>> + int written;
>
> FYI - int is < apr_ssize_t, please flip that to a signed representation
> that corresponds to sizeof(void*)
Sorry that I don't get it but
- apr_vformatter returns an 'int'
- we only use 'written' later on to compare it against -1. Nothing else
is done with 'written' afterwards.
So where is the point in using a signed representation that corresponds to
sizeof(void*)?
Regards
Rüdiger
Re: svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
rpluem@apache.org wrote:
> - apr_size_t written;
> + int written;
FYI - int is < apr_ssize_t, please flip that to a signed representation
that corresponds to sizeof(void*)
Bill
Re: svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
rpluem@apache.org wrote:
> - apr_size_t written;
> + int written;
FYI - int is < apr_ssize_t, please flip that to a signed representation
that corresponds to sizeof(void*)
Bill