You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ferenc-csaky (via GitHub)" <gi...@apache.org> on 2024/02/22 14:54:53 UTC

[PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

ferenc-csaky opened a new pull request, #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42

   Took the as minimum change as possible approach. Some pinned/excluded dependencies probably can be cleaned up, but I'd rather do that separately to not involve too many changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#issuecomment-1959622208

   cc @MartijnVisser 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1511744415


##########
flink-connector-hbase-e2e-tests/pom.xml:
##########
@@ -192,14 +192,6 @@ under the License.
 						</goals>
 						<configuration>
 							<artifactItems>

Review Comment:
   On line 60-65 we still have an inclusion of `flink-connector-hbase-1.4`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "Tan-JiaLiang (via GitHub)" <gi...@apache.org>.
Tan-JiaLiang commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1513778129


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########


Review Comment:
   `docs/data/hbase.yml` we still have an inclusion of hbase-1.4 on 21-22, See
   
   https://github.com/apache/flink-connector-hbase/blob/91d166d8c7ffb21ae065fce92618ecac74b7f9e7/docs/data/hbase.yml#L19-L24



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1514493277


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########


Review Comment:
   It was to be updated during the release, see for example the Kafka one https://github.com/apache/flink-connector-kafka/blob/v3.1/docs/data/kafka.yml



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1514510200


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########


Review Comment:
   Thanks both of you, corrected the file!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#issuecomment-1976709968

   @Tan-JiaLiang if you have some time can you PTAL?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1511745875


##########
flink-connector-hbase-e2e-tests/pom.xml:
##########
@@ -192,14 +192,6 @@ under the License.
 						</goals>
 						<configuration>
 							<artifactItems>

Review Comment:
   See https://github.com/apache/flink-connector-hbase/blob/7c9bda056cdded30daf39ef564e7396e22981c02/flink-connector-hbase-e2e-tests/pom.xml#L60-L65



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "Tan-JiaLiang (via GitHub)" <gi...@apache.org>.
Tan-JiaLiang commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1513905416


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########


Review Comment:
   @ferenc-csaky I think just remove lines 21-22 instead of the whole file, WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "ferenc-csaky (via GitHub)" <gi...@apache.org>.
ferenc-csaky commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1514397084


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########


Review Comment:
   I lamented on this a bit, I checked the `flink` and `flink-web` repos and did not find if this is shown anywhere. And after this point, there are no "variants" of the connector, so keeping the file does not really makes sense IMO. But I might be wrong or miss something.
   
   @MartijnVisser any thought about this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #42:
URL: https://github.com/apache/flink-connector-hbase/pull/42#discussion_r1514491885


##########
docs/content.zh/docs/connectors/table/hbase.md:
##########


Review Comment:
   > And after this point, there are no "variants" of the connector, so keeping the file does not really makes sense IMO. But I might be wrong or miss something.
   
   It must remain there, since it's used when generating the download links for the documentation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org