You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/08/25 06:23:53 UTC
[GitHub] [pulsar] srkukarni opened a new pull request #7890: convertFromConfig should support an overloading of cluster Name
srkukarni opened a new pull request #7890:
URL: https://github.com/apache/pulsar/pull/7890
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
Function workers have their cluster name in workerConfig.pulsarClusterName. When creating ServiceConfiguration we need to be able to override the clusterName
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 edited a comment on pull request #7890: convertFromConfig should support an overloading of cluster Name
Posted by GitBox <gi...@apache.org>.
gaoran10 edited a comment on pull request #7890:
URL: https://github.com/apache/pulsar/pull/7890#issuecomment-684810012
@srkukarni Hi, does it seem that the overloaded property `clusterName` is not used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng commented on a change in pull request #7890: convertFromConfig should support an overloading of cluster Name
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on a change in pull request #7890:
URL: https://github.com/apache/pulsar/pull/7890#discussion_r476230978
##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/common/configuration/PulsarConfigurationLoader.java
##########
@@ -173,7 +173,8 @@ private static boolean isEmpty(Object obj) {
* if conf has the field whose name is not contained in ServiceConfiguration and ignoreNonExistMember is false.
* @throws RuntimeException
*/
- public static ServiceConfiguration convertFrom(PulsarConfiguration conf, boolean ignoreNonExistMember) throws RuntimeException {
+ public static ServiceConfiguration convertFrom(PulsarConfiguration conf, boolean ignoreNonExistMember,
Review comment:
I would recommend not modifying these methods for the use case in the worker. It doesn't really make sense to modify the method to allow override of one specific config. We should just do the override in the worker code itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] srkukarni commented on pull request #7890: convertFromConfig should support an overloading of cluster Name
Posted by GitBox <gi...@apache.org>.
srkukarni commented on pull request #7890:
URL: https://github.com/apache/pulsar/pull/7890#issuecomment-680104747
@jerrypeng I've reworked the solution. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #7890: convertFromConfig should support an overloading of cluster Name
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #7890:
URL: https://github.com/apache/pulsar/pull/7890#issuecomment-684810012
Does it seem that the overloaded property `clusterName` is not used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jerrypeng merged pull request #7890: convertFromConfig should support an overloading of cluster Name
Posted by GitBox <gi...@apache.org>.
jerrypeng merged pull request #7890:
URL: https://github.com/apache/pulsar/pull/7890
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org