You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2022/01/22 06:59:03 UTC
svn commit: r1897324 - in /poi/trunk/poi-ooxml/src: main/java/org/apache/poi/xssf/streaming/SXSSFCell.java test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
Author: centic
Date: Sat Jan 22 06:59:03 2022
New Revision: 1897324
URL: http://svn.apache.org/viewvc?rev=1897324&view=rev
Log:
Avoid log-spam when using SXSSFWorkbook with auto-sizing
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFCell.java
poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFCell.java?rev=1897324&r1=1897323&r2=1897324&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFCell.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/streaming/SXSSFCell.java Sat Jan 22 06:59:03 2022
@@ -399,7 +399,9 @@ public class SXSSFCell extends CellBase
return ((RichTextValue)_value).getValue();
else {
String plainText = getStringCellValue();
- return getSheet().getWorkbook().getCreationHelper().createRichTextString(plainText);
+ // don't use the creation-helper here as it would spam the log with one line per row
+ //return getSheet().getWorkbook().getCreationHelper().createRichTextString(plainText);
+ return new XSSFRichTextString(plainText);
}
}
Modified: poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java?rev=1897324&r1=1897323&r2=1897324&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java (original)
+++ poi/trunk/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java Sat Jan 22 06:59:03 2022
@@ -95,6 +95,22 @@ public final class TestSXSSFFormulaEvalu
}
@Test
+ void testLogSpam() throws IOException {
+ try (SXSSFWorkbook wb = new SXSSFWorkbook(5)) {
+ SXSSFSheet s = wb.createSheet();
+ s.trackAllColumnsForAutoSizing();
+
+ for (int i = 0; i < 20; i++) {
+ s.createRow(i).createCell(0).setCellValue("1+2");
+ }
+
+ // previously this caused a large number of useless
+ // log-lines "SXSSF doesn't support Rich Text Strings..."
+ s.flushRows();
+ }
+ }
+
+ @Test
void testEvaluateRefOutsideWindowFails() throws IOException {
try (SXSSFWorkbook wb = new SXSSFWorkbook(5)) {
SXSSFSheet s = wb.createSheet();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org