You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-commits@hadoop.apache.org by Apache Wiki <wi...@apache.org> on 2010/09/07 22:25:02 UTC

[Hadoop Wiki] Update of "Hive/HowToContribute" by JohnSichi

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Hadoop Wiki" for change notification.

The "Hive/HowToContribute" page has been changed by JohnSichi.
http://wiki.apache.org/hadoop/Hive/HowToContribute?action=diff&rev1=27&rev2=28

--------------------------------------------------

    * This ensures that Review Board will send a notification email to the hive-dev list.
   * Use JIRA name and the short title for the "Summary" Field (eg: HIVE-1234: fix X Y Z)
   * You will need to click on the Publish button after you make a change.
-  * Don't upload the patch to JIRA until the final version has completed review (ie JIRA should contain only 1 patch that has been reviewed)
   * Use the [[CodeReviewChecklist| code review checklist]] as a guide when doing reviews
   * Reviewers can approve the patch by clicking on the "Ship it" option.
   * Should your patch earn a -1 review, set the issue status to 'Resume Progress', upload a patch to Review Board with necessary fixes and then set the status to 'Submit Patch' again.
  
+ ''NOTE:'' there was previously a rule about not uploading patches to JIRA until they had passed review board.  We may adopt this eventually, but for now, keep uploading all patch versions to JIRA.
  
  == Contributing your work ==
  Finally, patches should be ''attached'' to an issue report in [[http://issues.apache.org/jira/browse/HIVE|Jira]] via the '''Attach File''' link on the issue's Jira. Please add a comment that asks for a code review following our [[CodeReviewChecklist|code review checklist]]. Please note that the attachment should be granted license to ASF for inclusion in ASF works (as per the [[http://www.apache.org/licenses/LICENSE-2.0|Apache License]] §5).