You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2008/07/18 19:10:31 UTC
[jira] Created: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Add more unit tests to test appending to files in HDFS
------------------------------------------------------
Key: HADOOP-3790
URL: https://issues.apache.org/jira/browse/HADOOP-3790
Project: Hadoop Core
Issue Type: Bug
Components: test
Reporter: dhruba borthakur
Assignee: dhruba borthakur
A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3790) Add more unit tests to test
appending to files in HDFS
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638458#action_12638458 ]
Chris Douglas commented on HADOOP-3790:
---------------------------------------
The patch looks good. A few suggestions:
* Instead of local blocks, each of these should probably be separate tests. All can use the same static MiniDFSCluster using TestSetup, as in TestDatamerge, TestReduceFetch, etc.
* In TC11, does it make sense to check the return value of fs.rename?
* Since it's essentially dead code in trunk, it might make more sense to make TC3 part of HADOOP-4379 instead of enabling it once it can be expected to pass
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3790:
-------------------------------------------
Attachment: 3790_20081008.patch
3790_20081008.patch: Includes TC 1, 2, 3, 5, 11, 12 defined in https://issues.apache.org/jira/secure/attachment/12391788/20081008testplan.txt
Note that TC3 is currently disabled since HADOOP-4379
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3790:
-------------------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch, 3790_20081010.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3790) Add more unit tests to test
appending to files in HDFS
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639855#action_12639855 ]
Hudson commented on HADOOP-3790:
--------------------------------
Integrated in Hadoop-trunk #634 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/634/])
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch, 3790_20081010.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-3790:
--------------------------------
Fix Version/s: (was: 0.19.0)
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-3790:
--------------------------------
Fix Version/s: 0.19.0
Copying from HADOOP-3790: One interesting unit test would be introduce "appends" to existing unit test TestDatanodeDeath.
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.19.0
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3790) Add more unit tests to test
appending to files in HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638170#action_12638170 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3790:
------------------------------------------------
{noformat}
[exec] +1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
{noformat}
I tested the new tests locally.
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3790:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch, 3790_20081010.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3790:
-------------------------------------------
Priority: Blocker (was: Major)
Fix Version/s: 0.19.0
Issue Type: Test (was: Bug)
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3790) Add more unit tests to test
appending to files in HDFS
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638698#action_12638698 ]
Chris Douglas commented on HADOOP-3790:
---------------------------------------
+1 Looks good
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch, 3790_20081010.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3790) Add more unit tests to test appending
to files in HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3790:
-------------------------------------------
Attachment: 3790_20081010.patch
3790_20081010.patch
> Instead of local blocks, each of these should probably be separate tests. All can use the same static MiniDFSCluster using TestSetup, as in TestDatamerge, TestReduceFetch, etc.
Using TestSetup now.
> In TC11, does it make sense to check the return value of fs.rename?
Yes, we should check the return value. It turns out that TC11 was not implemented correctly. Good catch!
> Since it's essentially dead code in trunk, it might make more sense to make TC3 part of HADOOP-4379 instead of enabling it once it can be expected to pass
Removed here and, instead, posted in HADOOP-4379.
Thanks, Chris.
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch, 3790_20081010.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3790) Add more unit tests to test
appending to files in HDFS
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638773#action_12638773 ]
Hadoop QA commented on HADOOP-3790:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12391916/3790_20081010.patch
against trunk revision 703609.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3446/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3446/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3446/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3446/console
This message is automatically generated.
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.19.0
>
> Attachments: 3790_20081008.patch, 3790_20081010.patch
>
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3790) Add more unit tests to test
appending to files in HDFS
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE reassigned HADOOP-3790:
----------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE (was: dhruba borthakur)
> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>
> Key: HADOOP-3790
> URL: https://issues.apache.org/jira/browse/HADOOP-3790
> Project: Hadoop Core
> Issue Type: Bug
> Components: test
> Reporter: dhruba borthakur
> Assignee: Tsz Wo (Nicholas), SZE
>
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to have more unit tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.