You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/07/27 16:17:02 UTC

[maven-doxia] 01/01: [DOXIA-599] Replace element's name attribute with id attribute

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch DOXIA-599
in repository https://gitbox.apache.org/repos/asf/maven-doxia.git

commit 5cf32f19899dce1fca61809c7cae0cc8ca08a35b
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Wed Jul 27 18:16:54 2022 +0200

    [DOXIA-599] Replace <a /> element's name attribute with id attribute
---
 .../src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java  | 2 +-
 .../test/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSinkTest.java  | 2 +-
 .../src/test/java/org/apache/maven/doxia/module/fml/FmlParserTest.java  | 2 +-
 .../src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java  | 2 +-
 .../test/java/org/apache/maven/doxia/module/xhtml5/Xhtml5SinkTest.java  | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java b/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java
index a7bc84c7..5a9a4cc7 100644
--- a/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java
+++ b/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java
@@ -1771,7 +1771,7 @@ public class Xhtml5BaseSink
         }
 
         MutableAttributeSet att = new SinkEventAttributeSet();
-        att.addAttribute( Attribute.NAME, id );
+        att.addAttribute( Attribute.ID, id );
         att.addAttributes( atts );
 
         writeStartTag( HtmlMarkup.A, att );
diff --git a/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSinkTest.java b/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSinkTest.java
index 6bc76fbc..2ac2dbc8 100644
--- a/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSinkTest.java
+++ b/doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSinkTest.java
@@ -1254,7 +1254,7 @@ public class Xhtml5BaseSinkTest
             sink.close();
         }
 
-        assertEquals( "<a name=\"anchor\" style=\"bold\"></a>", writer.toString() );
+        assertEquals( "<a id=\"anchor\" style=\"bold\"></a>", writer.toString() );
     }
 
     /**
diff --git a/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlParserTest.java b/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlParserTest.java
index eeaab5ae..a439b3f4 100644
--- a/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlParserTest.java
+++ b/doxia-modules/doxia-module-fml/src/test/java/org/apache/maven/doxia/module/fml/FmlParserTest.java
@@ -285,7 +285,7 @@ public class FmlParserTest
             content = IOUtil.toString( reader );
         }
 
-        assertTrue( content.contains( "<a name=\"macro-definition\">Macro Question</a>" ) );
+        assertTrue( content.contains( "<a id=\"macro-definition\">Macro Question</a>" ) );
     }
 
     private void assertTextEvent( SinkEventElement textEvt, String string )
diff --git a/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java b/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java
index 3f2ca708..3e8613f8 100644
--- a/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java
+++ b/doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java
@@ -293,7 +293,7 @@ public class XdocSinkTest
     /** {@inheritDoc} */
     protected String getAnchorBlock( String anchor )
     {
-        return "<a name=\"" + anchor + "\">" + anchor + "</a>";
+        return "<a id=\"" + anchor + "\">" + anchor + "</a>";
     }
 
     /** {@inheritDoc} */
diff --git a/doxia-modules/doxia-module-xhtml5/src/test/java/org/apache/maven/doxia/module/xhtml5/Xhtml5SinkTest.java b/doxia-modules/doxia-module-xhtml5/src/test/java/org/apache/maven/doxia/module/xhtml5/Xhtml5SinkTest.java
index 093db562..9b900454 100644
--- a/doxia-modules/doxia-module-xhtml5/src/test/java/org/apache/maven/doxia/module/xhtml5/Xhtml5SinkTest.java
+++ b/doxia-modules/doxia-module-xhtml5/src/test/java/org/apache/maven/doxia/module/xhtml5/Xhtml5SinkTest.java
@@ -297,7 +297,7 @@ public class Xhtml5SinkTest
     /** {@inheritDoc} */
     protected String getAnchorBlock( String anchor )
     {
-        return "<a name=\"" + anchor + "\">" + anchor + "</a>";
+        return "<a id=\"" + anchor + "\">" + anchor + "</a>";
     }
 
     /** {@inheritDoc} */