[GitHub] [atlas] gmcoringa commented on a change in pull request #23: ability to enable audits in SSL enabled cassandra backend

[GitBox <gi...@apache.org>]

gmcoringa commented on a change in pull request #23: ability to enable audits in SSL enabled cassandra backend
URL: https://github.com/apache/atlas/pull/23#discussion_r293782042
 
 

 ##########
 File path: repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 ##########
 @@ -217,7 +253,22 @@ void createSession() throws AtlasException {
     Cluster.Builder cassandraClusterBuilder = Cluster.builder();
 
     String hostname = APPLICATION_PROPERTIES.getString(CASSANDRA_HOSTNAME_PROPERTY, "localhost");
-    Cluster cluster = cassandraClusterBuilder.addContactPoint(hostname).withClusterName(clusterName).withPort(port).build();
+
+    Cluster cluster = null;
+    if (isSSLEnabled) {
+      if (StringUtils.isNotEmpty(username) && StringUtils.isNotEmpty(password)) {
 
 Review comment:
   User credentials should not be locked into ssl, there are scenarios where only authentication is enought.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services