You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/12 11:02:05 UTC

[GitHub] ashb commented on a change in pull request #4225: [AIRFLOW-3383] Rotate fernet keys.

ashb commented on a change in pull request #4225: [AIRFLOW-3383] Rotate fernet keys.
URL: https://github.com/apache/incubator-airflow/pull/4225#discussion_r240969490
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -614,6 +614,16 @@ def next_execution(args):
         print(None)
 
 
+@cli_utils.action_logging
+def rotate_credentials(args):
 
 Review comment:
   Code looks good, only comment is that I think this name needs changing - even knowning what the PR was for I thought this was about rotating the credentials _in_ the connection.
   
   How about `reencrypt_connections`, `rotate_fernet_key`, or `rotate_encryption_keys`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services