[GitHub] [phoenix] gjacoby126 commented on a change in pull request #1365: PHOENIX-6611 Multiple IndexTool bugs

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #1365:
URL: https://github.com/apache/phoenix/pull/1365#discussion_r770861899



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
##########
@@ -493,6 +493,10 @@ public Job getJob() throws Exception {
                 }
                 if (useSnapshot || (!isLocalIndexBuild && pDataTable.isTransactional())) {
                     PhoenixConfigurationUtil.setCurrentScnValue(configuration, maxTimeRange);
+                    if (indexVerifyType != IndexVerifyType.NONE) {
+                        LOGGER.warn("Verification is not supported for client index rebuilds,"

Review comment:
       The error message seems wrong -- verification is supported for some client-initiated index rebuilds, just not ones using a mapper other than the server build one. If you mean that the direct mapper creates the mutations and writes them as a client, that's probably not clear to the end user. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org