You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2015/10/06 04:21:35 UTC

[GitHub] spark pull request: [SPARK-10941] [SQL] Refactor AggregateFunction...

Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/8973#issuecomment-145723873
  
    Alright, I've gone ahead and filed a JIRA, performed some more renaming, and added a _ton_ more Scaladoc to the new split interfaces in order to clarify how they're used. Reviewers, please pay attention to how I renamed some of the attribute and buffer fields in order to clarify field offset handling, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org