You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/03/15 00:24:35 UTC

[kudu-CR] [write throttling-itest] relax threshold to avoid flakiness

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18320


Change subject: [write_throttling-itest] relax threshold to avoid flakiness
......................................................................

[write_throttling-itest] relax threshold to avoid flakiness

I saw a failure [1] of the WriteThrottlingTest.ThrottleWriteRpcPerSec
test scenario during gerrit pre-commit tests for [2]:

  src/kudu/integration-tests/write_throttling-itest.cc:107
  Expected: (qps) <= (TARGET_QPS * 1.2f), actual: 121.467 vs 120

This patch relaxes the threshold for the target QPS: 1.2 --> 1.25.
FWIW, the token-based accounting could be affected by scheduler
anomalies and bursts in request rates, so there isn't anything
unexpected here.

[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/25223/
[2] http://gerrit.cloudera.org:8080/18318

Change-Id: Iad3335595b02e66cdc588755b8f53c77442d5736
---
M src/kudu/integration-tests/write_throttling-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/18320/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad3335595b02e66cdc588755b8f53c77442d5736
Gerrit-Change-Number: 18320
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [write throttling-itest] relax threshold to avoid flakiness

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18320 )

Change subject: [write_throttling-itest] relax threshold to avoid flakiness
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad3335595b02e66cdc588755b8f53c77442d5736
Gerrit-Change-Number: 18320
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 17 Mar 2022 20:27:09 +0000
Gerrit-HasComments: No

[kudu-CR] [write throttling-itest] relax threshold to avoid flakiness

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18320 )

Change subject: [write_throttling-itest] relax threshold to avoid flakiness
......................................................................

[write_throttling-itest] relax threshold to avoid flakiness

I saw a failure [1] of the WriteThrottlingTest.ThrottleWriteRpcPerSec
test scenario during gerrit pre-commit tests for [2]:

  src/kudu/integration-tests/write_throttling-itest.cc:107
  Expected: (qps) <= (TARGET_QPS * 1.2f), actual: 121.467 vs 120

This patch relaxes the threshold for the target QPS: 1.2 --> 1.25.
FWIW, the token-based accounting could be affected by scheduler
anomalies and bursts in request rates, so there isn't anything
unexpected here.

[1] http://jenkins.kudu.apache.org/job/kudu-gerrit/25223/
[2] http://gerrit.cloudera.org:8080/18318

Change-Id: Iad3335595b02e66cdc588755b8f53c77442d5736
Reviewed-on: http://gerrit.cloudera.org:8080/18320
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/write_throttling-itest.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad3335595b02e66cdc588755b8f53c77442d5736
Gerrit-Change-Number: 18320
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)