You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "jiangfucheng (via GitHub)" <gi...@apache.org> on 2023/04/23 13:55:50 UTC

[GitHub] [apisix] jiangfucheng opened a new pull request, #9358: docs: fix typo

jiangfucheng opened a new pull request, #9358:
URL: https://github.com/apache/apisix/pull/9358

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes # (issue)
   
   ### Checklist
   
   - [ ] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9358: docs: fix typo

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9358:
URL: https://github.com/apache/apisix/pull/9358#discussion_r1186717457


##########
docs/en/latest/getting-started/load-balancing.md:
##########
@@ -44,6 +44,7 @@ curl -i "http://127.0.0.1:9180/apisix/admin/routes" -X PUT -d '
 You will receive an `HTTP/1.1 201 OK` response if the route was created successfully.
 
 :::info
+
 1. The `pass_host` field is set to `node` to pass the host header to the upstream.
 2. The `scheme` field is set to `https` to enable TLS when sending requests to the upstream.
 :::

Review Comment:
   Need a blank here too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] jiangfucheng commented on a diff in pull request #9358: docs: fix typo

Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng commented on code in PR #9358:
URL: https://github.com/apache/apisix/pull/9358#discussion_r1186722650


##########
docs/en/latest/getting-started/load-balancing.md:
##########
@@ -44,6 +44,7 @@ curl -i "http://127.0.0.1:9180/apisix/admin/routes" -X PUT -d '
 You will receive an `HTTP/1.1 201 OK` response if the route was created successfully.
 
 :::info
+
 1. The `pass_host` field is set to `node` to pass the host header to the upstream.
 2. The `scheme` field is set to `https` to enable TLS when sending requests to the upstream.
 :::

Review Comment:
   Yes, otherwise the CI will fail. However, I have discovered that all of the formatting errors in the documentation have been fixed by https://github.com/apache/apisix/pull/9379. Therefore, this PR can be closed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] jiangfucheng closed pull request #9358: docs: fix typo

Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng closed pull request #9358: docs: fix typo
URL: https://github.com/apache/apisix/pull/9358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9358: docs: fix typo

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9358:
URL: https://github.com/apache/apisix/pull/9358#discussion_r1186717582


##########
docs/zh/latest/installation-guide.md:
##########
@@ -101,7 +101,7 @@ helm install apisix apisix/apisix --create-namespace  --namespace apisix
 
 <TabItem value="rpm">
 
-该安装方法适用于 CentOS 7 和 CentOS 8。如果你选择该方法安装 APISIX，需要先安装 etcd。具体安装方法请参考[安装 etcd](#安装-etcd)。
+该安装方法适用于 CentOS 7 和 CentOS 8。如果你选择该方法安装 APISIX，需要先安装 etcd。具体安装方法请参考 [安装 etcd](#安装-etcd)。

Review Comment:
   No need to change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9358: docs: fix typo

Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9358:
URL: https://github.com/apache/apisix/pull/9358#discussion_r1186717542


##########
docs/zh/latest/getting-started.md:
##########
@@ -143,13 +143,13 @@ curl -sL https://run.api7.ai/apisix/quickstart | sh
 curl "http://127.0.0.1:9080" --head | grep Server
 ```
 
-I如果一切顺利，将输出如下信息。
+如果一切顺利，将输出如下信息。
 
 ```text
 Server: APISIX/3.1.0
 ```
 
-现在，你已经成功安装并运行了 APISIX ！
+现在，你已经成功安装并运行了 APISIX！

Review Comment:
   No need to change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org