You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/05 15:59:00 UTC

[jira] [Commented] (AIRFLOW-3014) Password column on connection table should be longer

    [ https://issues.apache.org/jira/browse/AIRFLOW-3014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604600#comment-16604600 ] 

ASF GitHub Bot commented on AIRFLOW-3014:
-----------------------------------------

bravefoot opened a new pull request #3851: AIRFLOW-3014 Increase possible length of passwords in connection table
URL: https://github.com/apache/incubator-airflow/pull/3851
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3014
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [X ] Here are some details about my PR, including screenshots of any UI changes:
   Adds a migration script to increase the size of the password column in the connection table
   
   ### Tests
   
   - [X ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   I did not see unit tests around migration scripts. If I was mistaken, I'd be happy to add a test.
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Password column on connection table should be longer
> ----------------------------------------------------
>
>                 Key: AIRFLOW-3014
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3014
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Brian Campbell
>            Priority: Minor
>
> The password column in the connection table has a maximum length of 500 characters. In some cases this is insufficient. For example, AWS provides passwords for ECR that, when encrypted, are longer than 3400 characters. In order to use the docker operator with ECR, you will need a longer password column on the connection table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)