You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by bo...@apache.org on 2023/07/28 00:22:46 UTC
[kyuubi] branch master updated: [KYUUBI #5101] [MINOR] Remove unused StringBuilders in ResultSets
This is an automated email from the ASF dual-hosted git repository.
bowenliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new b2ddef199 [KYUUBI #5101] [MINOR] Remove unused StringBuilders in ResultSets
b2ddef199 is described below
commit b2ddef1996c554026b22931ce4697f6052108606
Author: liangbowen <li...@gf.com.cn>
AuthorDate: Fri Jul 28 08:22:30 2023 +0800
[KYUUBI #5101] [MINOR] Remove unused StringBuilders in ResultSets
### _Why are the changes needed?_
- remove 2 unused string builders in `KyuubiQueryResultSet` and `KyuubiArrowQueryResultSet`, which are only appended separator only and never queried again
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
Closes #5101 from bowenliang123/unused-sb.
Closes #5101
ccb6fb77d [liangbowen] remove never queried StringBuilders
Authored-by: liangbowen <li...@gf.com.cn>
Signed-off-by: liangbowen <li...@gf.com.cn>
---
.../org/apache/kyuubi/jdbc/hive/KyuubiArrowQueryResultSet.java | 7 -------
.../java/org/apache/kyuubi/jdbc/hive/KyuubiQueryResultSet.java | 7 -------
2 files changed, 14 deletions(-)
diff --git a/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiArrowQueryResultSet.java b/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiArrowQueryResultSet.java
index fda70f463..54491b2d6 100644
--- a/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiArrowQueryResultSet.java
+++ b/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiArrowQueryResultSet.java
@@ -250,9 +250,6 @@ public class KyuubiArrowQueryResultSet extends KyuubiArrowBasedResultSet {
metadataResp = client.GetResultSetMetadata(metadataReq);
Utils.verifySuccess(metadataResp.getStatus());
- StringBuilder namesSb = new StringBuilder();
- StringBuilder typesSb = new StringBuilder();
-
TTableSchema schema = metadataResp.getSchema();
if (schema == null || !schema.isSetColumns()) {
// TODO: should probably throw an exception here.
@@ -262,10 +259,6 @@ public class KyuubiArrowQueryResultSet extends KyuubiArrowBasedResultSet {
List<TColumnDesc> columns = schema.getColumns();
for (int pos = 0; pos < schema.getColumnsSize(); pos++) {
- if (pos != 0) {
- namesSb.append(",");
- typesSb.append(",");
- }
String columnName = columns.get(pos).getColumnName();
columnNames.add(columnName);
normalizedColumnNames.add(columnName.toLowerCase());
diff --git a/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiQueryResultSet.java b/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiQueryResultSet.java
index f06ada5d4..82ea74a01 100644
--- a/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiQueryResultSet.java
+++ b/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiQueryResultSet.java
@@ -223,9 +223,6 @@ public class KyuubiQueryResultSet extends KyuubiBaseResultSet {
metadataResp = client.GetResultSetMetadata(metadataReq);
Utils.verifySuccess(metadataResp.getStatus());
- StringBuilder namesSb = new StringBuilder();
- StringBuilder typesSb = new StringBuilder();
-
TTableSchema schema = metadataResp.getSchema();
if (schema == null || !schema.isSetColumns()) {
// TODO: should probably throw an exception here.
@@ -235,10 +232,6 @@ public class KyuubiQueryResultSet extends KyuubiBaseResultSet {
List<TColumnDesc> columns = schema.getColumns();
for (int pos = 0; pos < schema.getColumnsSize(); pos++) {
- if (pos != 0) {
- namesSb.append(",");
- typesSb.append(",");
- }
String columnName = columns.get(pos).getColumnName();
columnNames.add(columnName);
normalizedColumnNames.add(columnName.toLowerCase());