[GitHub] [samza] cameronlee314 commented on a change in pull request #1526: SAMZA-2679: Add missing Override annotations

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1526:
URL: https://github.com/apache/samza/pull/1526#discussion_r699569470



##########
File path: samza-api/src/main/java/org/apache/samza/checkpoint/CheckpointV1.java
##########
@@ -44,7 +44,7 @@ public CheckpointV1(Map<SystemStreamPartition, String> offsets) {
     this.offsets = offsets;
   }
 
-  public short getVersion() {
+  @Override public short getVersion() {

Review comment:
       Looks like the style in the other parts of code are to have `@Override` on a new line above the method. i.e.:
   ```
   @Override
   public short getVersion() {
   ```
   Sorry to request this, but could you please update that in each of the files?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org