You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "ctubbsii (via GitHub)" <gi...@apache.org> on 2023/06/29 22:10:39 UTC
[GitHub] [accumulo] ctubbsii opened a new pull request, #3556: Remove unneeded handling of exceptions not thrown
ctubbsii opened a new pull request, #3556:
URL: https://github.com/apache/accumulo/pull/3556
* Use more specific AutoCloseable type for metrics closer, since it doesn't thrown exceptions, and there's no point in forcing the caller to handle them because the super-class has `throws Exception` that this one doesn't use
* Narrow the catch block on compaction failures to handle only RuntimeExceptions, since it can't throw any checked exceptions
I noticed the opportunity to make these tiny improvements after seeing the wide net `catch (Exception e)` statements while reviewing #3555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #3556: Remove unneeded handling of exceptions not thrown
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii merged PR #3556:
URL: https://github.com/apache/accumulo/pull/3556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org