Re: [PATCH] New error code needed for javahl binding. Next try. Repost

[Patrick Mayweg <ma...@qint.de>]

Hi,
this is a repost of my request for a new error code. Could I have any 
comments please?
Patrick

Hi,
after the comment by  Justin Erenkrantz, I have renamed the exception to
SVN_ERR_BINDING_EXCEPTION_PASSTHRU. The reason for the new error code is
unchanged, but the error code is no longer specific to the javahl binding.
Patrick

[[[
* subversion/include/svn_error_codes.h
    added new error code for passing pending a binding exception thru 
subversion.
]]]



Patrick Mayweg wrote:

> Hi,
> the javahl binding needs a new error code. The binding calls 
> java-callbacks. During these calls, java exceptions maybe thrown. The 
> binding can detect these exceptions. This not catching these 
> exceptions. What I want to do is the stop the subversion processing by 
> returning an svn_error_t to subversion. When this error is processed 
> in the outer javahl binding code, I do not have to throw a new 
> exception, but keep the existing exception pending. For that I need a 
> new error.
> Patrick
>

Re: [PATCH] New error code needed for javahl binding. Next try. Repost

[Branko Čibej <br...@xbc.nu>]

Patrick Mayweg wrote:

>Index: subversion/include/svn_error_codes.h
>===================================================================
>--- subversion/include/svn_error_codes.h	(revision 9921)
>+++ subversion/include/svn_error_codes.h	(working copy)
>@@ -853,6 +853,14 @@
>               SVN_ERR_MISC_CATEGORY_START + 19,
>               "Incompatible library version")
> 
>+  /* language bindings may catch/detect exception in their language while
>+     doing callbacks. To pass these exceptions thru the subversion code
>+     unchanged, a special error code is needed. This error code is not
>+     user visibible */
>+  SVN_ERRDEF (SVN_ERR_BINDING_EXCEPTION_PASSTHRU,
>+              SVN_ERR_MISC_CATEGORY_START + 20,
>+              "Binding exception has been passed thru")
>+
>  
>

How about calling this just SVN_ERR_BINDING_EXCEPTION, and instead of
creating a new error code, make it an alias for
SVN_ERR_SWIG_PY_EXCEPTION_SET (and deprecating that one, of course). I
don't think we need two such error codes, or a Python-specific one. Also
if I remember your usage correctly, there's no chance of this error code
being misinterpreted.

-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org