You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (Created) (JIRA)" <ji...@apache.org> on 2011/11/19 12:26:51 UTC

[jira] [Created] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

benchmark tests always fail on windows because directory cannot be removed
--------------------------------------------------------------------------

                 Key: LUCENE-3583
                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Uwe Schindler


This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154930#comment-13154930 ] 

Uwe Schindler commented on LUCENE-3583:
---------------------------------------

I still think we should also commit Robert's patch.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155136#comment-13155136 ] 

Robert Muir commented on LUCENE-3583:
-------------------------------------

Shai: thanks for getting to the bottom of this!
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Shai Erera (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154959#comment-13154959 ] 

Shai Erera commented on LUCENE-3583:
------------------------------------

Committed test fixes to 3x and trunk.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Simon Willnauer (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-3583:
------------------------------------

    Fix Version/s:     (was: 3.6)
                   3.5
    
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Shai Erera (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154950#comment-13154950 ] 

Shai Erera commented on LUCENE-3583:
------------------------------------

Ok found it: testInvalidFormat expected exceptions to be thrown while the algorithm runs, and so tasks.close() wasn't called. I'll change the code to close in a try-finally, for all Closeable resources.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Shai Erera (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera resolved LUCENE-3583.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0
                   3.6
         Assignee: Shai Erera
    Lucene Fields: New,Patch Available  (was: New)

Committed rev 1204826 (3x).
Ported changes to trunk in rev 1204828.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Shai Erera (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154937#comment-13154937 ] 

Shai Erera commented on LUCENE-3583:
------------------------------------

You're right, I didn't notice it. I'll work on it now.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3583:
--------------------------------

    Attachment: LUCENE-3583.patch

with this patch the benchmark tests pass *most* of the time on my windows computer.

But sometimes they still fail (with the same filenames involved)... I have no idea why.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153476#comment-13153476 ] 

Robert Muir commented on LUCENE-3583:
-------------------------------------

hudson needs a space in its folder too :)

The problem is BenchmarkTestCase, i'm sure i introduced the bug when i fixed another bug (it used TEMP_DIR directly).
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: benchmark-test-output.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-3583:
----------------------------------

    Attachment: benchmark-test-output.txt
    
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Uwe Schindler
>         Attachments: benchmark-test-output.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-3583:
----------------------------------

          Environment: Only fails for Lucene trunk
    Affects Version/s: 4.0

Only fails for Lucene trunk, seems to be related to the additional cleanupo by the removal of new IndexSearcher(directory).
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: benchmark-test-output.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3583:
--------------------------------

    Affects Version/s: 3.5

Setting affects 3.x, becuase i'm gonna backport my previous fix that unravelled this problem.

                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153507#comment-13153507 ] 

Robert Muir commented on LUCENE-3583:
-------------------------------------

By the way this is the reason these tests fail now:
http://svn.apache.org/viewvc/lucene/dev/branches/lucene2621/modules/benchmark/src/test/org/apache/lucene/benchmark/BenchmarkTestCase.java?view=diff&r1=1201966&r2=1201967&pathrev=1201967

Before they just created files underneath TEMP_DIR directly and were not closing things and were silently wrong... so the
problems have been here a while.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Shai Erera (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154947#comment-13154947 ] 

Shai Erera commented on LUCENE-3583:
------------------------------------

Committed Robert's changes to trunk rev 1204851. However after porting to 3x and running the tests, LineDocSourceTest consistently fails with this:

ant test -Dtestcase=LineDocSourceTest -Dtests.seed=-2895bf521e2206c:0:4f1f278a279ce441

I'm investigating (don't know if it fails on trunk too yet).
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Shai Erera (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-3583:
-------------------------------

    Attachment: LUCENE-3583.patch

Patch fixes the problem in LineDocSourceTest - add tasks.close() (otherwise LDS keeps a reader open on the file).

I intend to commit shortly, after verifying all tests pass and no other such changes are required.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-3583.patch, LUCENE-3583.patch, benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153489#comment-13153489 ] 

Robert Muir commented on LUCENE-3583:
-------------------------------------

It looks to me like the problem is inside LineDocSourceTest:doIndexAndSearchTest

i ran the test with -Dtestmethod=testWithDocsName, and it passes if i comment out the call to this method.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: benchmark-test-output.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153488#comment-13153488 ] 

Robert Muir commented on LUCENE-3583:
-------------------------------------

OK it fails even if you have no space in the directory.

So i'm guessing this test leaves a file open (outside of mockdirectorywrapper)

We need FileSystem.setDefault(new MockWindowsFileSystem())...
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: benchmark-test-output.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-3583:
----------------------------------

    Attachment: io-event-log.txt

Here the complete I/O event log created by sysinternals process monitor when running test TestLineDocSource
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3583) benchmark tests always fail on windows because directory cannot be removed

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153498#comment-13153498 ] 

Robert Muir commented on LUCENE-3583:
-------------------------------------

When LuceneTestCase cannot delete a file that it wants to, I'm gonna see if we can improve the output for starters.

This would make it easier to debug issues like this.
                
> benchmark tests always fail on windows because directory cannot be removed
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-3583
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3583
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>         Environment: Only fails for Lucene trunk
>            Reporter: Uwe Schindler
>         Attachments: benchmark-test-output.txt, io-event-log.txt
>
>
> This seems to be a bug recently introduced. I have no idea what's wrong. Attached is a log file, reproduces everytime.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org