You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:28:17 UTC

[GitHub] [airflow] gabrielvieira37 opened a new pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

gabrielvieira37 opened a new pull request #16396:
URL: https://github.com/apache/airflow/pull/16396


   Fix docker compose version to handle ```depends_on``` feature called ```condition```. 
   Versions above or equal 3 does not support this feature, it did not port healthcheck dependencies. 
   Change version to to 2.4, the latest version below 3 that support that feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #16396:
URL: https://github.com/apache/airflow/pull/16396#issuecomment-859751599






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] gabrielvieira37 commented on pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

Posted by GitBox <gi...@apache.org>.

gabrielvieira37 commented on pull request #16396:
URL: https://github.com/apache/airflow/pull/16396#issuecomment-859729246






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #16396:
URL: https://github.com/apache/airflow/pull/16396#issuecomment-859697024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #16396:
URL: https://github.com/apache/airflow/pull/16396#issuecomment-859717822






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #16396:
URL: https://github.com/apache/airflow/pull/16396#issuecomment-866759261


   Hey @gabrielvieira37  - have you tested with 1.29.* ? Do you still see the problem? I am closing the issue now unless you come back and tell us that it did not work with 1.29 (I also tested with 1.29 and it works just fine).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] gabrielvieira37 edited a comment on pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

Posted by GitBox <gi...@apache.org>.

gabrielvieira37 edited a comment on pull request #16396:
URL: https://github.com/apache/airflow/pull/16396#issuecomment-859979372


   docker-compose version 1.25.0. I use ```docker-compose```.
   The changes between 1.29.2 (current) and 1.25.0 did not handle those errors. 
   I followed the airflow tutorial to use that docker-compose file. But it was not running at all.
   When I read about it a little bit more I found out the issues that I am talking here.
   Have you tried to run that docker-compose file there ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed pull request #16396: Fix docker compose version to be the latest below 3, depends_on condition now works fine.

Posted by GitBox <gi...@apache.org>.

potiuk closed pull request #16396:
URL: https://github.com/apache/airflow/pull/16396


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org