You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/11/29 20:23:13 UTC
svn commit: r1546630 - in /tomcat/trunk/java/org/apache/catalina:
Authenticator.java authenticator/AuthenticatorBase.java
Author: markt
Date: Fri Nov 29 19:23:13 2013
New Revision: 1546630
URL: http://svn.apache.org/r1546630
Log:
Remove unnecessary "throws ServletException"
Modified:
tomcat/trunk/java/org/apache/catalina/Authenticator.java
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
Modified: tomcat/trunk/java/org/apache/catalina/Authenticator.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Authenticator.java?rev=1546630&r1=1546629&r2=1546630&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/Authenticator.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Authenticator.java Fri Nov 29 19:23:13 2013
@@ -51,5 +51,5 @@ public interface Authenticator {
public void login(String userName, String password, Request request)
throws ServletException;
- public void logout(Request request) throws ServletException;
+ public void logout(Request request);
}
Modified: tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=1546630&r1=1546629&r2=1546630&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java Fri Nov 29 19:23:13 2013
@@ -849,7 +849,7 @@ public abstract class AuthenticatorBase
}
@Override
- public void logout(Request request) throws ServletException {
+ public void logout(Request request) {
register(request, request.getResponse(), null,
null, null, null);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1546630 - in /tomcat/trunk/java/org/apache/catalina:
Authenticator.java authenticator/AuthenticatorBase.java
Posted by Mark Thomas <ma...@apache.org>.
On 29/11/2013 20:23, Konstantin Kolinko wrote:
> 2013/11/29 <ma...@apache.org>:
>> Author: markt
>> Date: Fri Nov 29 19:23:13 2013
>> New Revision: 1546630
>>
>> URL: http://svn.apache.org/r1546630
>> Log:
>> Remove unnecessary "throws ServletException"
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/Authenticator.java
>> tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
>>
>> Modified: tomcat/trunk/java/org/apache/catalina/Authenticator.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Authenticator.java?rev=1546630&r1=1546629&r2=1546630&view=diff
>> ==============================================================================
>> --- tomcat/trunk/java/org/apache/catalina/Authenticator.java (original)
>> +++ tomcat/trunk/java/org/apache/catalina/Authenticator.java Fri Nov 29 19:23:13 2013
>> @@ -51,5 +51,5 @@ public interface Authenticator {
>> public void login(String userName, String password, Request request)
>> throws ServletException;
>>
>> - public void logout(Request request) throws ServletException;
>> + public void logout(Request request);
>
> This is an interface. Why custom authenticators aren't allowed to
> throw a ServletException here?
They could but since it wasn't being used by Tomcat and I suspect it
isn't used by customer authenticators either, I removed it. It can
always be added back if required.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1546630 - in /tomcat/trunk/java/org/apache/catalina:
Authenticator.java authenticator/AuthenticatorBase.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2013/11/29 <ma...@apache.org>:
> Author: markt
> Date: Fri Nov 29 19:23:13 2013
> New Revision: 1546630
>
> URL: http://svn.apache.org/r1546630
> Log:
> Remove unnecessary "throws ServletException"
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/Authenticator.java
> tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
>
> Modified: tomcat/trunk/java/org/apache/catalina/Authenticator.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Authenticator.java?rev=1546630&r1=1546629&r2=1546630&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/Authenticator.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/Authenticator.java Fri Nov 29 19:23:13 2013
> @@ -51,5 +51,5 @@ public interface Authenticator {
> public void login(String userName, String password, Request request)
> throws ServletException;
>
> - public void logout(Request request) throws ServletException;
> + public void logout(Request request);
This is an interface. Why custom authenticators aren't allowed to
throw a ServletException here?
> }
>
> Modified: tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=1546630&r1=1546629&r2=1546630&view=diff
> ==============================================================================
> --- tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java Fri Nov 29 19:23:13 2013
> @@ -849,7 +849,7 @@ public abstract class AuthenticatorBase
> }
>
> @Override
> - public void logout(Request request) throws ServletException {
> + public void logout(Request request) {
> register(request, request.getResponse(), null,
> null, null, null);
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org