You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Paul Russell <pa...@luminas.co.uk> on 2000/10/09 18:32:46 UTC

ComponentPoolController

... should be a Component...

diff -c -r1.1.2.1 ComponentPoolController.java
*** src/org/apache/cocoon/sitemap/ComponentPoolController.java  2000/10/08 20:58:58     1.1.2.1
--- src/org/apache/cocoon/sitemap/ComponentPoolController.java  2000/10/09 16:29:39
***************
*** 25,31 ****
   * @author <a href="mailto:Giacomo.Pati@pwr.ch">Giacomo Pati</a>
   * @version CVS $Revision: 1.1.2.1 $ $Date: 2000/10/08 20:58:58 $
   */
! public class ComponentPoolController implements PoolController, ThreadSafe {
  
      /** Initial increase/decrease amount */
      public final static int DEFAULT_AMOUNT = 16;
--- 25,31 ----
   * @author <a href="mailto:Giacomo.Pati@pwr.ch">Giacomo Pati</a>
   * @version CVS $Revision: 1.1.2.1 $ $Date: 2000/10/08 20:58:58 $
   */
! public class ComponentPoolController implements PoolController, ThreadSafe, Component {
  
      /** Initial increase/decrease amount */
      public final static int DEFAULT_AMOUNT = 16;
***************
*** 68,71 ****
      */
          return amount;
      }
! }
\ No newline at end of file
--- 68,71 ----
      */
          return amount;
      }
! }

-- 
Paul Russell                               <pa...@luminas.co.uk>
Technical Director,                   http://www.luminas.co.uk
Luminas Ltd.

Re: ComponentPoolController

Posted by Paul Russell <pa...@luminas.co.uk>.
On Tue, Oct 10, 2000 at 06:59:58AM +0200, Giacomo Pati wrote:
> Giacomo Pati wrote:
> > Paul Russell wrote:
> > > ... should be a Component...
> > Can you explain why a PoolController should be a Component?
> Uh, that hurts :). Because *I* have made it pluggable as a Component.

Heh. I guessed as much. The only reason I mentioned it is because
it won't run without it (the sitemap loads it using load_component,
iirc).. :)

Paul
-- 
Paul Russell                               <pa...@luminas.co.uk>
Technical Director,                   http://www.luminas.co.uk
Luminas Ltd.

Re: ComponentPoolController

Posted by Giacomo Pati <Gi...@pwr.ch>.
Giacomo Pati wrote:
> 
> Paul Russell wrote:
> >
> > ... should be a Component...
> 
> Can you explain why a PoolController should be a Component?

Uh, that hurts :). Because *I* have made it pluggable as a Component.

Patch applied
 
Giacomo

-- 
PWR GmbH, Organisation & Entwicklung      Tel:   +41 (0)1  856 2202
Giacomo Pati, CTO/CEO                     Fax:   +41 (0)1  856 2201
Hintereichenstrasse 7                     Mobil: +41 (0)78 759 7703
CH-8166 Niederweningen                    Mailto:Giacomo.Pati@pwr.ch
                                          Web:   http://www.pwr.ch

Re: ComponentPoolController

Posted by Giacomo Pati <Gi...@pwr.ch>.
Paul Russell wrote:
> 
> ... should be a Component...

Can you explain why a PoolController should be a Component?

Giacomo 

> 
> diff -c -r1.1.2.1 ComponentPoolController.java
> *** src/org/apache/cocoon/sitemap/ComponentPoolController.java  2000/10/08 20:58:58     1.1.2.1
> --- src/org/apache/cocoon/sitemap/ComponentPoolController.java  2000/10/09 16:29:39
> ***************
> *** 25,31 ****
>    * @author <a href="mailto:Giacomo.Pati@pwr.ch">Giacomo Pati</a>
>    * @version CVS $Revision: 1.1.2.1 $ $Date: 2000/10/08 20:58:58 $
>    */
> ! public class ComponentPoolController implements PoolController, ThreadSafe {
> 
>       /** Initial increase/decrease amount */
>       public final static int DEFAULT_AMOUNT = 16;
> --- 25,31 ----
>    * @author <a href="mailto:Giacomo.Pati@pwr.ch">Giacomo Pati</a>
>    * @version CVS $Revision: 1.1.2.1 $ $Date: 2000/10/08 20:58:58 $
>    */
> ! public class ComponentPoolController implements PoolController, ThreadSafe, Component {
> 
>       /** Initial increase/decrease amount */
>       public final static int DEFAULT_AMOUNT = 16;
> ***************
> *** 68,71 ****
>       */
>           return amount;
>       }
> ! }
> \ No newline at end of file
> --- 68,71 ----
>       */
>           return amount;
>       }
> ! }
> 
> --
> Paul Russell                               <pa...@luminas.co.uk>
> Technical Director,                   http://www.luminas.co.uk
> Luminas Ltd.

-- 
PWR GmbH, Organisation & Entwicklung      Tel:   +41 (0)1  856 2202
Giacomo Pati, CTO/CEO                     Fax:   +41 (0)1  856 2201
Hintereichenstrasse 7                     Mobil: +41 (0)78 759 7703
CH-8166 Niederweningen                    Mailto:Giacomo.Pati@pwr.ch
                                          Web:   http://www.pwr.ch