[GitHub] sohami commented on a change in pull request #1417: DRILL-6645: Transform TopN in Lateral Unnest pipeline to Sort and Limit.

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1417: DRILL-6645: Transform TopN in Lateral Unnest pipeline to Sort and Limit.
URL: https://github.com/apache/drill/pull/1417#discussion_r207584274
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/LateralUnnestRowIDVisitor.java
 ##########
 @@ -43,7 +43,7 @@ public static Prel insertRowID(Prel prel){
   public Prel visitPrel(Prel prel, Boolean isRightOfLateral) throws RuntimeException {
     List<RelNode> children = getChildren(prel, isRightOfLateral);
     if (isRightOfLateral) {
-      return prel.addImplicitRowIDCol(children);
+      return prel.getRelForLateralUnnestPipeline(children);
     } else {
       return (Prel) prel.copy(prel.getTraitSet(), children);
 
 Review comment:
   given that Unnest can also be on left side of Lateral shouldn't we add implicit column for operators on left subtree of Lateral as well iff Unnest is present ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services