[GitHub] dlg99 commented on a change in pull request #1789: Cache InetSocketAddress if hostname is IPAddress

[GitBox <gi...@apache.org>]

dlg99 commented on a change in pull request #1789: Cache InetSocketAddress if hostname is IPAddress
URL: https://github.com/apache/bookkeeper/pull/1789#discussion_r231316265
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/net/BookieSocketAddress.java
 ##########
 @@ -38,11 +39,19 @@
     // Member fields that make up this class.
     private final String hostname;
     private final int port;
+    private final boolean isHostnameIPAddress;
+    private final InetSocketAddress socketAddress;
 
 Review comment:
   I'd do Optional<InetSocketAddress>
   assign Optional.empty() if it is empty
   and use 
   socketAddress.orElseGet(() -> new InetSocketAddress(hostname, port)) to get address as needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services