[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10729: Add sample method to IndexingServiceClient

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on a change in pull request #10729:
URL: https://github.com/apache/druid/pull/10729#discussion_r551746315



##########
File path: server/src/main/java/org/apache/druid/client/indexing/SamplerResponse.java
##########
@@ -58,6 +64,27 @@ public int getNumRowsIndexed()
     return data;
   }
 
+  @Override
+  public boolean equals(Object o)
+  {
+    if (this == o) {
+      return true;
+    }
+    if (o == null || getClass() != o.getClass()) {
+      return false;
+    }
+    SamplerResponse that = (SamplerResponse) o;
+    return getNumRowsRead() == that.getNumRowsRead() &&
+           getNumRowsIndexed() == that.getNumRowsIndexed() &&
+           Objects.equals(getData(), that.getData());

Review comment:
       this may not do the correct thing always. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org