[GitHub] [iceberg] snazy commented on a change in pull request #2826: Build: Upgrade to Gradle 7.x

[GitBox <gi...@apache.org>]

snazy commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r674245564



##########
File path: build.gradle
##########
@@ -656,27 +707,37 @@ if (jdkVersion == '8') {
         exclude group: 'org.pentaho' // missing dependency
         exclude group: 'org.slf4j', module: 'slf4j-log4j12'
       }
+
+      compileOnly("org.apache.orc:orc-core::nohive") {

Review comment:
       This kind of dependency w/ excludes is repeated. I think, it would be cleaner to add a new configuration named something like `orc-core-nohive` so so and add that configuration as a dependency instead of the repeated lines. WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org