You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/05/04 17:40:50 UTC

[GitHub] [samza] cameronlee314 commented on a change in pull request #1332: SAMZA-2442: Update doc/tutorials from config factory to config loader

cameronlee314 commented on a change in pull request #1332:
URL: https://github.com/apache/samza/pull/1332#discussion_r419609081



##########
File path: samza-test/src/main/python/deployment.py
##########
@@ -76,7 +76,7 @@ def setup_suite():
 
   # Setup Samza job deployer.
   samza_job_deployer = SamzaJobYarnDeployer({
-    'config_factory': c('samza_config_factory'),
+    'config_factory': c('samza_config_loader_factory'),

Review comment:
       Does the key here need to be `config_loader_factory`? You changed `samza_job_yarn_deployer.py` to use `config_loader_factory`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org