You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/11/10 12:06:49 UTC
[GitHub] [qpid-proton] jiridanek opened a new pull request #276: PROTON-2295 Pin go to oldest supported version in GH Action
jiridanek opened a new pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276
This is mainly tp avoid the broken 1.15.3 which is default on macOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #276: PROTON-2295 avoid broken Go 1.15.3 on macOS CI
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-726023651
> -- Found Go: /Users/runner/hostedtoolcache/go/1.15.4/x64/bin/go (go version go1.15.4 darwin/amd64) (1.15).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on pull request #276: PROTON-2295 avoid broken Go 1.15.3 on macOS CI
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-726022881
Looks good, squash + push.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on pull request #276: PROTON-2295 Pin go to oldest supported version in GH Action
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-726008093
I'd also go with the newest here, since we are presumably testing older versions in e.g Travis already. We can make the change specific to OSX for now though just to get that working since its specific to a particular version issue there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek merged pull request #276: PROTON-2295 avoid broken Go 1.15.3 on macOS CI
Posted by GitBox <gi...@apache.org>.
jiridanek merged pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] jiridanek commented on pull request #276: PROTON-2295 avoid broken Go 1.15.3 on macOS CI
Posted by GitBox <gi...@apache.org>.
jiridanek commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-726012768
I've changed the PR to run conditionally only on macOS. I'll now watch the GHA, how it runs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] gemmellr commented on pull request #276: PROTON-2295 avoid broken Go 1.15.3 on macOS CI
Posted by GitBox <gi...@apache.org>.
gemmellr commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-726018835
Great. Seems to have worked.
Stylistic nit, I think Its nicer if the if is the first element of a step, it makes it easier to discern if the step is relevant or not when reading the config...admittedly it is clear from the output/status details for the job that a given step has run or not though.
Could perhaps also rename the step to "Setup go (Mac OS)" to distinguish it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] astitcher commented on pull request #276: PROTON-2295 Pin go to oldest supported version in GH Action
Posted by GitBox <gi...@apache.org>.
astitcher commented on pull request #276:
URL: https://github.com/apache/qpid-proton/pull/276#issuecomment-725015670
Since this pin is for every CI build environment not just the failing MacOS, I think it would be better to use the *newest* supported and working version rather than the oldest supported version. I pretty sure that is the case for python (at least when 3.6 was pinned newer versions of python failed under CI on at least some of the CI platforms)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org