You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "OIiveirra (via GitHub)" <gi...@apache.org> on 2026/10/23 10:33:14 UTC
[PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
OIiveirra opened a new pull request, #69533:
URL: https://github.com/apache/doris/pull/69533
### What problem does this PR solve?
Issue Number: N/A (no public GitHub issue)
Related PR: #69473
Problem Summary:
Port the LakeSoul diagnostic logging fix to `branch-3.1`. The retained scanner logs complete parameters at INFO, including object storage credentials carried in `options`. The FE scan node also logs complete catalog properties at DEBUG.
Log only the query ID and batch size when opening the scanner, and remove the catalog-property dump. Authentication options continue to reach the reader unchanged.
Add the same focused unit regressions and an explicit `lakesoul-scanner-tests` Maven profile. The deprecated scanner remains excluded from default builds, and normal LakeSoul catalog creation remains disabled.
### Release note
Prevent sensitive LakeSoul scanner parameters and catalog properties from being written to logs.
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
Validation on branch-3.1 with JDK 17 and a matching Thrift 0.16.0 generator:
- `LakeSoulJniScannerTest`: 3 tests passed, covering INFO, DEBUG, and a missing query ID; credentials still reach the native reader.
- `LakeSoulScanNodeTest`: 1 test passed, verifying credentials stay in scan options and out of DEBUG logs.
- All 4 tests fail on credential-leak assertions with the original 3.1 production logging, and pass with this fix. Fresh Surefire XML reports show no skipped tests or errors.
- Targeted Checkstyle: 0 violations. `git diff --check` passed.
Native I/O is isolated with Mockito. No live LakeSoul SQL scan was run; the branch rejects LakeSoul catalog creation.
- Behavior changed:
- [ ] No.
- [x] Yes. Scanner startup logs contain the query ID and batch size instead of the full parameters; FE no longer logs complete catalog properties.
- Does this need documentation?
- [x] No.
- [ ] Yes.
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra closed pull request #69533: [fix](lakesoul) Avoid logging credentials on branch-3.1
URL: https://github.com/apache/doris/pull/69533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6362938332
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6363568769
Codex automated review failed and did not complete.
Error: Review recovery stopped: No final review submission was declared
Workflow run: https://github.com/apache/doris/actions/runs/39943892509
Please inspect the workflow logs and rerun the review after the underlying issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6363177606
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6363490703
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6363014974
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6363260755
Codex automated review failed and did not complete.
Error: Review recovery stopped: No final review submission was declared
Workflow run: https://github.com/apache/doris/actions/runs/39941760878
Please inspect the workflow logs and rerun the review after the underlying issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6362995693
Codex automated review failed and did not complete.
Error: Review recovery stopped: No final review submission was declared
Workflow run: https://github.com/apache/doris/actions/runs/39940102074
Please inspect the workflow logs and rerun the review after the underlying issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6362917661
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://doris.apache.org/community/how-to-contribute/review-and-ci).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "OIiveirra (via GitHub)" <gi...@apache.org>.
OIiveirra commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6362941245
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](lakesoul) Avoid logging credentials on branch-3.1 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #69533:
URL: https://github.com/apache/doris/pull/69533#issuecomment-6363077097
Codex automated review failed and did not complete.
Error: Review recovery stopped: No final review submission was declared
Workflow run: https://github.com/apache/doris/actions/runs/39940622722
Please inspect the workflow logs and rerun the review after the underlying issue is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org