You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2017/11/20 17:46:56 UTC
[GitHub] utzig commented on a change in pull request #50: oic: Allow to provide GET query parameters
utzig commented on a change in pull request #50: oic: Allow to provide GET query parameters
URL: https://github.com/apache/mynewt-newtmgr/pull/50#discussion_r152062292
##########
File path: nmxact/nmcoap/nmcoap.go
##########
@@ -75,7 +77,12 @@ func CreateGet(isTcp bool, resUri string, token []byte) (coap.Message, error) {
}
m := buildMessage(isTcp, p)
- m.SetPathString(resUri)
+
+ q = strings.Split(resUri, "?")
+ m.SetPathString(q[0])
+ if (len(q) > 1) {
Review comment:
btw, those parenthesis are not idiomatic go, should be just `if len(q) > 1 {`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services